Add on type conversion of tab char to spaces

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: David Thompson <davthomp@redhat.com>

Author: evidolob

src/languageservice/services/yamlOnTypeFormatting.ts

@@ -50,4 +50,14 @@ export function doDocumentOnTypeFormatting(
       return [TextEdit.insert(position, '  ')];
     }
   }
+
+  if (params.ch === '\t' && params.options.insertSpaces) {
+    return [
+      TextEdit.replace(
+        Range.create(position.line, position.character - 1, position.line, position.character),
+        ' '.repeat(params.options.tabSize)
+      ),
+    ];
+  }
+  return;
 }

src/yamlServerInit.ts

@@ -128,6 +128,7 @@ export class YAMLServerInit {
         documentFormattingProvider: !this.yamlSettings.clientDynamicRegisterSupport,
         documentOnTypeFormattingProvider: {
           firstTriggerCharacter: '\n',
+          moreTriggerCharacter: ['\t'],
         },
         documentRangeFormattingProvider: false,
         definitionProvider: true,

test/yamlOnTypeFormatting.test.ts

@@ -17,58 +17,66 @@ function createParams(position: Position): DocumentOnTypeFormattingParams {
   };
 }
 describe('YAML On Type Formatter', () => {
-  it('should react on "\n" only', () => {
-    const doc = setupTextDocument('foo:');
-    const params = createParams(Position.create(1, 0));
-    params.ch = '\t';
-    const result = doDocumentOnTypeFormatting(doc, params);
-    expect(result).is.undefined;
-  });
+  describe('On Enter Formatter', () => {
+    it('should add indentation for mapping', () => {
+      const doc = setupTextDocument('foo:\n');
+      const params = createParams(Position.create(1, 0));
+      const result = doDocumentOnTypeFormatting(doc, params);
+      expect(result).to.deep.include(TextEdit.insert(Position.create(1, 0), '  '));
+    });
 
-  it('should add indentation for mapping', () => {
-    const doc = setupTextDocument('foo:\n');
-    const params = createParams(Position.create(1, 0));
-    const result = doDocumentOnTypeFormatting(doc, params);
-    expect(result).to.deep.include(TextEdit.insert(Position.create(1, 0), '  '));
-  });
+    it('should add indentation for scalar array items', () => {
+      const doc = setupTextDocument('foo:\n  - some\n  ');
+      const pos = Position.create(2, 2);
+      const params = createParams(pos);
+      const result = doDocumentOnTypeFormatting(doc, params);
+      expect(result[0]).to.eqls(TextEdit.insert(pos, '- '));
+    });
 
-  it('should add indentation for scalar array items', () => {
-    const doc = setupTextDocument('foo:\n  - some\n  ');
-    const pos = Position.create(2, 2);
-    const params = createParams(pos);
-    const result = doDocumentOnTypeFormatting(doc, params);
-    expect(result[0]).to.eqls(TextEdit.insert(pos, '- '));
-  });
+    it('should add indentation for mapping in array', () => {
+      const doc = setupTextDocument('some:\n  - arr:\n  ');
+      const pos = Position.create(2, 2);
+      const params = createParams(pos);
+      const result = doDocumentOnTypeFormatting(doc, params);
+      expect(result).to.deep.include(TextEdit.insert(pos, '    '));
+    });
 
-  it('should add indentation for mapping in array', () => {
-    const doc = setupTextDocument('some:\n  - arr:\n  ');
-    const pos = Position.create(2, 2);
-    const params = createParams(pos);
-    const result = doDocumentOnTypeFormatting(doc, params);
-    expect(result).to.deep.include(TextEdit.insert(pos, '    '));
-  });
+    it('should replace all spaces in newline', () => {
+      const doc = setupTextDocument('some:\n    ');
+      const pos = Position.create(1, 0);
+      const params = createParams(pos);
+      const result = doDocumentOnTypeFormatting(doc, params);
+      expect(result).to.deep.include.members([
+        TextEdit.del(Range.create(pos, Position.create(1, 3))),
+        TextEdit.insert(pos, '  '),
+      ]);
+    });
 
-  it('should replace all spaces in newline', () => {
-    const doc = setupTextDocument('some:\n    ');
-    const pos = Position.create(1, 0);
-    const params = createParams(pos);
-    const result = doDocumentOnTypeFormatting(doc, params);
-    expect(result).to.deep.include.members([TextEdit.del(Range.create(pos, Position.create(1, 3))), TextEdit.insert(pos, '  ')]);
-  });
+    it('should keep all non white spaces characters in newline', () => {
+      const doc = setupTextDocument('some:\n  foo');
+      const pos = Position.create(1, 0);
+      const params = createParams(pos);
+      const result = doDocumentOnTypeFormatting(doc, params);
+      expect(result).is.undefined;
+    });
 
-  it('should keep all non white spaces characters in newline', () => {
-    const doc = setupTextDocument('some:\n  foo');
-    const pos = Position.create(1, 0);
-    const params = createParams(pos);
-    const result = doDocumentOnTypeFormatting(doc, params);
-    expect(result).is.undefined;
+    it('should add indentation for multiline string', () => {
+      const doc = setupTextDocument('some: |\n');
+      const pos = Position.create(1, 0);
+      const params = createParams(pos);
+      const result = doDocumentOnTypeFormatting(doc, params);
+      expect(result).to.deep.include(TextEdit.insert(pos, '  '));
+    });
   });
 
-  it('should add indentation for multiline string', () => {
-    const doc = setupTextDocument('some: |\n');
-    const pos = Position.create(1, 0);
-    const params = createParams(pos);
-    const result = doDocumentOnTypeFormatting(doc, params);
-    expect(result).to.deep.include(TextEdit.insert(pos, '  '));
+  describe('On Tab Formatter', () => {
+    it('should replace Tab with spaces', () => {
+      const doc = setupTextDocument('some:\n\t');
+      const pos = Position.create(1, 1);
+      const params = createParams(pos);
+      params.ch = '\t';
+      const result = doDocumentOnTypeFormatting(doc, params);
+      expect(result).to.deep.include(TextEdit.replace(Range.create(1, 0, 1, 1), '  '));
+    });
   });
 });