Upgrade Arabic Repo to Align with React 19

.eslintrc

@@ -2,7 +2,11 @@
   "root": true,
   "extends": "next/core-web-vitals",
   "parser": "@typescript-eslint/parser",
-  "plugins": ["@typescript-eslint", "eslint-plugin-react-compiler", "local-rules"],
+  "plugins": [
+    "@typescript-eslint",
+    "eslint-plugin-react-compiler",
+    "local-rules"
+  ],
   "rules": {
     "no-unused-vars": "off",
     "@typescript-eslint/no-unused-vars": ["error", {"varsIgnorePattern": "^_"}],
@@ -30,7 +34,7 @@
         "react-hooks/exhaustive-deps": "off",
         "react/no-unknown-property": "off",
         "react-compiler/react-compiler": "off",
-        "local-rules/lint-markdown-code-blocks": "error"
+        "local-rules/lint-markdown-code-blocks": "warn"
       }
     }
   ]

.github/workflows/analyze_comment.yml

@@ -10,7 +10,7 @@ permissions:
   contents: read
   issues: write
   pull-requests: write
-  
+
 jobs:
   comment:
     runs-on: ubuntu-latest
@@ -20,6 +20,8 @@ jobs:
     steps:
       - name: Download base branch bundle stats
         uses: dawidd6/action-download-artifact@268677152d06ba59fcec7a7f0b5d961b6ccd7e1e
+        continue-on-error: true
+        id: download-analysis
         with:
           workflow: analyze.yml
           run_id: ${{ github.event.workflow_run.id }}
@@ -28,6 +30,7 @@ jobs:
 
       - name: Download PR number
         uses: dawidd6/action-download-artifact@268677152d06ba59fcec7a7f0b5d961b6ccd7e1e
+        if: steps.download-analysis.outcome == 'success'
         with:
           workflow: analyze.yml
           run_id: ${{ github.event.workflow_run.id }}
@@ -36,7 +39,7 @@ jobs:
 
       - name: Get comment body
         id: get-comment-body
-        if: success()
+        if: steps.download-analysis.outcome == 'success'
         run: |
           echo 'body<<EOF' >> $GITHUB_OUTPUT
           echo '' >>  $GITHUB_OUTPUT
@@ -54,6 +57,7 @@ jobs:
 
       - name: Comment
         uses: marocchino/sticky-pull-request-comment@52423e01640425a022ef5fd42c6fb5f633a02728
+        if: steps.download-analysis.outcome == 'success'
         with:
           header: next-bundle-analysis
           number: ${{ steps.get-comment-body.outputs.pr-number }}

eslint-local-rules/__tests__/lint-markdown-code-blocks.test.js

@@ -11,12 +11,7 @@ const path = require('path');
 const {ESLint} = require('eslint');
 const plugin = require('..');
 
-const FIXTURES_DIR = path.join(
-  __dirname,
-  'fixtures',
-  'src',
-  'content'
-);
+const FIXTURES_DIR = path.join(__dirname, 'fixtures', 'src', 'content');
 const PARSER_PATH = path.join(__dirname, '..', 'parser.js');
 
 function createESLint({fix = false} = {}) {
@@ -53,11 +48,7 @@ async function lintFixture(name, {fix = false} = {}) {
 
 async function run() {
   const basicResult = await lintFixture('basic-error.md');
-  assert.strictEqual(
-    basicResult.messages.length,
-    1,
-    'expected one diagnostic'
-  );
+  assert.strictEqual(basicResult.messages.length, 1, 'expected one diagnostic');
   assert(
     basicResult.messages[0].message.includes('Calling setState during render'),
     'expected message to mention setState during render'
@@ -91,9 +82,7 @@ async function run() {
     fix: true,
   });
   assert(
-    duplicateFixed.output.includes(
-      "{expectedErrors: {'react-compiler': [4]}}"
-    ),
+    duplicateFixed.output.includes("{expectedErrors: {'react-compiler': [4]}}"),
     'expected duplicates to be rewritten to a single canonical block'
   );
   assert(
@@ -118,14 +107,12 @@ async function run() {
     fix: true,
   });
   assert(
-    malformedFixed.output.includes(
-      "{expectedErrors: {'react-compiler': [4]}}"
-    ),
+    malformedFixed.output.includes("{expectedErrors: {'react-compiler': [4]}}"),
     'expected malformed metadata to be replaced with canonical form'
   );
 }
 
-run().catch(error => {
+run().catch((error) => {
   console.error(error);
   process.exitCode = 1;
 });

eslint-local-rules/package.json

@@ -6,6 +6,12 @@
   "scripts": {
     "test": "node __tests__/lint-markdown-code-blocks.test.js"
   },
+  "dependencies": {
+    "@babel/core": "^7.12.9",
+    "@babel/parser": "^7.12.9",
+    "babel-plugin-react-compiler": "^1.0.0",
+    "eslint": "^7.0.0"
+  },
   "devDependencies": {
     "eslint-mdx": "^2"
   }

eslint-local-rules/rules/metadata.js

@@ -84,15 +84,19 @@ function parseExpectedErrorsEntries(rawEntries) {
 
   if (parsed && typeof parsed === 'object') {
     for (const [key, value] of Object.entries(parsed)) {
-      entries[key] = normalizeEntryValues(Array.isArray(value) ? value.flat() : value);
+      entries[key] = normalizeEntryValues(
+        Array.isArray(value) ? value.flat() : value
+      );
     }
   }
 
   return entries;
 }
 
 function parseExpectedErrorsToken(tokenText) {
-  const match = tokenText.match(/^\{\s*expectedErrors\s*:\s*(\{[\s\S]*\})\s*\}$/);
+  const match = tokenText.match(
+    /^\{\s*expectedErrors\s*:\s*(\{[\s\S]*\})\s*\}$/
+  );
   if (!match) {
     return null;
   }
@@ -203,7 +207,9 @@ function cloneMetadata(metadata) {
 }
 
 function findExpectedErrorsToken(metadata) {
-  return metadata.tokens.find((token) => token.type === 'expectedErrors') || null;
+  return (
+    metadata.tokens.find((token) => token.type === 'expectedErrors') || null
+  );
 }
 
 function getCompilerExpectedLines(metadata) {

eslint-local-rules/rules/react-compiler.js

@@ -98,17 +98,19 @@ function runReactCompiler(code, filename) {
       continue;
     }
 
-    const loc = typeof detail.primaryLocation === 'function'
-      ? detail.primaryLocation()
-      : null;
+    const loc =
+      typeof detail.primaryLocation === 'function'
+        ? detail.primaryLocation()
+        : null;
 
     if (loc == null || typeof loc === 'symbol') {
       continue;
     }
 
-    const message = typeof detail.printErrorMessage === 'function'
-      ? detail.printErrorMessage(result.sourceCode, {eslint: true})
-      : detail.description || 'Unknown React Compiler error';
+    const message =
+      typeof detail.printErrorMessage === 'function'
+        ? detail.printErrorMessage(result.sourceCode, {eslint: true})
+        : detail.description || 'Unknown React Compiler error';
 
     diagnostics.push({detail, loc, message});
   }