Upgrade Arabic Repo to Align with React 19 #637
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Arabic React documentation repository to align with React 19.2, merging upstream changes while preserving all existing Arabic translations. The update includes React 19 features, React Compiler documentation, and fixes for compilation and TypeScript issues.
Key changes:
- Merged React 19.0.0 upstream updates (294 files)
- Updated React version from 18.3.1 to 19.2
- Added copyright headers from Meta Platforms, Inc.
Reviewed Changes
Copilot reviewed 233 out of 294 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/siteConfig.js | Updated React version to 19.2 |
| src/sidebarLearn.json | Updated sidebar titles (reverted Arabic to English) |
| src/sidebarReference.json | Added React 19 APIs and removed deprecated ones |
| src/utils/compileMDX.ts | Updated for React 19 JSX runtime compatibility |
| src/styles/index.css | Changed font URLs from CDN to local paths |
| Multiple utility files | Added Meta Platforms copyright headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 219 out of 318 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/content/reference/react-dom/static/resumeAndPrerenderToNodeStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/static/resumeAndPrerenderToNodeStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/static/resumeAndPrerenderToNodeStream.md
Outdated
Show resolved
Hide resolved
|
Thanks @Mohamed-Hashem for opening this — the work you’ve put into this is very much appreciated.
The correct way to sync is by using rebase or cherry-pick, not squash merging. I’ve just updated the repo to be up to date with reactjs/react.dev, which introduced several merge conflicts in your PR. Could you please resolve the conflicts so I can review and merge it? Thank you for your contribution! 🙏 |
- Merged 294 files with React 19.0.0 updates from upstream - Added React Compiler documentation - Added new React 19 APIs (Activity, ViewTransition, useEffectEvent) - Updated server rendering APIs - Removed deprecated APIs (findDOMNode, render, hydrate, etc.) - 56 new files need Arabic translation (see files-needing-translation.txt)
- Fixed JSX namespace errors in Icon components (React 19 compatibility) - Added @types/prop-types dependency - Added React Compiler dependencies to eslint-local-rules - Fixed all Icon components to use React.JSX.IntrinsicElements - Added proper TypeScript types to all Icon component props
… the exact same versions of all dependencies, including nested dependencies
- Changed all font URLs from https://react.dev/fonts/ to /fonts/ - Ensures site works independently without external dependencies - Improves loading performance and reliability - Addresses Copilot code review feedback
- Resolves React 19 peer dependency conflict with @codesandbox/sandpack-react - Allows npm to install with --legacy-peer-deps automatically
- Upgraded from 2.13.5 to 2.20.0 which natively supports React 19 - Removed .npmrc workaround - no longer needed - This is a proper solution instead of using legacy-peer-deps
- @headlessui/react: ^1.7.0 ^2.2.9 (React 19 support) - react-collapsed: 4.0.4 ^4.2.0 (React 19 support) - Fixes all peer dependency conflicts for Vercel build
Translated sidebar files while preserving technical terms: sidebarLearn.json: - Main sections: 'تعلم React', 'البدأ', 'بداية سريعة' - Installation: 'التثبيت', 'إنشاء تطبيق React', 'بناء تطبيق React من الصفر' - Setup: 'الإعداد', 'تجهيز المحرر', 'أدوات مطوري React' - Learning sections: 'وصف واجهة المستخدم', 'إضافة التفاعلية', 'إدارة الحالة', 'مخارج الطوارئ' - React Compiler subsections: 'مقدمة', 'التثبيت', 'التبني التدريجي', 'تصحيح الأخطاء واستكشاف المشاكل' sidebarHome.json: - 'توثيق React', 'بداية سريعة', 'التثبيت', 'الإعداد' - Sections: 'تعلم React', 'شارك معنا', 'ابق على اطلاع' - 'المكونات', 'الإعدادات', 'تصريف المكتبات', 'مجتمع React', 'مدونة React' sidebarCommunity.json: - 'المجتمع', 'شارك معنا' - 'مؤتمرات React', 'لقاءات React', 'فيديوهات React' - 'تعرف على الفريق', 'المساهمون في التوثيق', 'الترجمات' - 'شكر وتقدير', 'سياسة الإصدارات' sidebarBlog.json: - 'المدونة', 'ابق على اطلاع' sidebarReference.json: - 'مرجع API', 'نظرة عامة', 'المكونات' - 'الإعدادات', 'تصريف المكتبات' - Rules section: 'قواعد React', 'Components و Hooks يجب أن تكون نقية' Technical terms preserved: React, Hooks, APIs, TypeScript, Compiler, DevTools, Server Components, Server Functions, Directives, Legacy APIs, Client APIs, Server APIs, Static APIs
…larity, and enhance documentation links for hooks and server actions.
…r handling in forms, and enhance static path generation logic
…n TypeScript usage, invalid ARIA prop warnings, deprecation warnings for react-dom/test-utils and react-test-renderer, and special props warnings.
… download analysis outcome
…les linting level to warn
…improved accessibility and understanding.
… accessibility and understanding
Add Space Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eStream.md Remove extra word 'the'. Should be 'If rendering is successful'. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eStream.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eStream.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Thank you, @AhmedBaset I have completed the updates as requested. The PR has been rebased successfully, all merge conflicts have been resolved, and all CI checks are passing. Please review at your convenience. I'm happy to make any additional changes if needed. |
2 participants
Upgrade Arabic Repo to Align with React 19
📋 Summary
This PR merges the latest updates from the upstream react.dev repository (React 19.0.0) while preserving all existing Arabic translations and fixing all documentation issues.
Demo Live: https://ar-react-dev.vercel.app
Doing so will "erase" the commits from main and cause them to appear as conflicts the next time we merge.
This PR contains merge commits from the upstream repository. Squashing these commits will break the git history and cause conflicts in future syncs with the upstream react.dev repository and the
@react-translations-bot.✅ Required merge method: Use "Create a merge commit" or "Rebase and merge"
✨ Changes
✅ Completed
📊 Statistics
🔄 New Content Added
React 19 Features
Activity,ViewTransition,useEffectEvent,cacheSignal, etc.Documentation Updates
🌐 UI Localization Completed
🐛 Documentation Fixes Applied
Based on Copilot AI review feedback:
Additional Fixes After Rebase
56 new English files require Arabic translation:
📄 Complete list: See
files-needing-translation.txt🔧 Technical Details
Dependencies Updated
Breaking Changes Handled
findDOMNode,render,hydrate,createFactory,unmountComponentAtNodeESLint & Sandpack Fixes
react-hooksplugin from.eslintrc(provided by eslint-config-next)Rebase Strategy
git rebase(not squash) to preserve commit references@react-translations-botcompatibility✅ Testing & Validation
All CI Checks Passing ✅