Skip to content

Catch all exceptions in HeartbeatWriteTimerCallback and HeartbeatReadTimerCallback to avoid crash #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Catch all exceptions in HeartbeatWriteTimerCallback and HeartbeatReadTimerCallback to avoid crash #1876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 18 additions & 21 deletions projects/RabbitMQ.Client/Impl/Connection.Heartbeat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,19 @@ private void NotifyHeartbeatListener()
_heartbeatDetected = true;
}

// Intentionally declared `async void` because `System.Threading.Timer` requires a void callback.
// Catch all exceptions in it: any exceptions unhandled by the method might lead to the process crash
private async void HeartbeatReadTimerCallback(object? state)
{
if (_heartbeatReadTimer is null)
try
{
return;
}
if (_heartbeatReadTimer is null)
{
return;
}

bool shouldTerminate = false;
bool shouldTerminate = false;

try
{
if (false == _closed)
{
if (_heartbeatDetected)
Expand Down Expand Up @@ -131,34 +133,29 @@ await FinishCloseAsync(cts.Token)
_heartbeatReadTimer?.Change((int)Heartbeat.TotalMilliseconds, Timeout.Infinite);
}
}
catch (OperationCanceledException)
{
if (false == _mainLoopCts.IsCancellationRequested)
{
throw;
}
}
catch (ObjectDisposedException)
{
// timer is already disposed,
// e.g. due to shutdown
}
catch (NullReferenceException)
catch (Exception)
{
// timer has already been disposed from a different thread after null check
// this event should be rare
// ignore
// peer unavailability. See rabbitmq/rabbitmq-dotnet-client#638 for details.
}
}

// Intentionally declared `async void` because `System.Threading.Timer` requires a void callback.
// Catch all exceptions in it: any exceptions unhandled by the method might lead to the process crash
private async void HeartbeatWriteTimerCallback(object? state)
{
if (_heartbeatWriteTimer is null)
{
return;
}

try
{
if (_heartbeatWriteTimer is null)
{
return;
}

if (false == _closed)
{
await WriteAsync(Client.Impl.Framing.Heartbeat.GetHeartbeatFrame(), _mainLoopCts.Token)
Expand Down
Loading