Catch all exceptions in HeartbeatWriteTimerCallback and HeartbeatReadTimerCallback to avoid crash #1876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
My application crashed with the following stack trace
Checking the code I discovered that
HeartbeatReadTimerCallbackhasasync voidsignature that may crash the application in case of exceptionI'm using
7.1.14.0.9I also took the opportunity to modify
HeartbeatWriteTimerCallbackeven if it was already catching exceptions.I didn't found other
async voidin the code.Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments