Skip to content

gh-138189: Document type slots, and other constants, as part of Limited API #138190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 4, 2025
Merged

gh-138189: Document type slots, and other constants, as part of Limited API #138190

merged 9 commits into from
Nov 4, 2025

Conversation

@encukou
Copy link
Member

@encukou encukou commented Aug 27, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 27, 2025
Open
@encukou encukou marked this pull request as ready for review September 15, 2025 12:33
@encukou
Copy link
Member Author

encukou commented Nov 4, 2025

@ZeroIntensity, do you want to review this? It would help #141004 :)

ZeroIntensity
ZeroIntensity approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happily!

I have one little nitpick about type annotations, but this looks good to me otherwise. Very happy to see these documented.

encukou and others added 2 commits November 4, 2025 22:14
@encukou @ZeroIntensity
Apply suggestions from code review
604dbd4 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@encukou
Merge branch 'main' into document-slots
c9750f0
@ZeroIntensity ZeroIntensity mentioned this pull request Nov 4, 2025
Open
@encukou
Copy link
Member Author

encukou commented Nov 4, 2025

Thank you!

@encukou encukou merged commit d81e1ef into python:main Nov 4, 2025
46 checks passed
@encukou encukou deleted the document-slots branch November 4, 2025 21:58
@encukou encukou added the needs backport to 3.14 bugs and security fixes label Nov 4, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 4, 2025

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 4, 2025

Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d81e1ef0f3a7c63f5d246e4cf918700016b72489 3.14

@ZeroIntensity ZeroIntensity mentioned this pull request Nov 5, 2025
Open
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 6, 2025
@encukou @ZeroIntensity @hugovk
[3.14] pythongh-138189: Document type slots, and other constants, as …
d15db04 
…part of Limited API (pythonGH-138190)

(cherry picked from commit d81e1ef)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2025

GH-141131 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
encukou added a commit that referenced this pull request Nov 6, 2025
@hugovk @encukou @ZeroIntensity
[3.14] gh-138189: Document type slots, and other constants, as part o…
7168553 
…f Limited API (GH-138190) (GH-141131)

(cherry picked from commit d81e1ef)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
encukou added a commit to encukou/cpython that referenced this pull request Nov 7, 2025
@encukou @ZeroIntensity
[3.13] pythongh-138189: Document type slots, and other constants, as …
da30411 
…part of Limited API (pythonGH-138190)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
(cherry picked from commit d81e1ef)
@bedevere-app
Copy link

bedevere-app bot commented Nov 7, 2025

GH-141193 is a backport of this pull request to the 3.13 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

@encukou encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou @ZeroIntensity