gh-140260: Fix data race in _struct module initialization with subinterpreters #140909
+66
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
needs backport to 3.14
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Please add a test stressing this.
picnixz
reviewed
Nov 2, 2025
Silence compiler warning about the unused result; the init cannot fail.
Use an exec wrapper for subinterpreter execution and assert None results instead of calling support.run_in_subinterp
Member
|
I think the failing job will be solved by a rebase. |
Member
kumaraditya303
approved these changes
Nov 6, 2025
Member
|
It did (now fixed thanks to Victor), but I don't think it broke mobile. Maybe it's sequential tests, or cross-compilation? |
Contributor
|
Seems like Android and iOS do not support subinterpreters so the test should be skipped on those platforms. |
Member
|
Good catch, I disabled auto-merge for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.