Skip to content

Allow Symfony 8 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
Open

Allow Symfony 8 #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0158c01
Allow PHP 8
VincentLanglet Nov 5, 2025
ad50b77
Stop emulate PHP 8.3.99
VincentLanglet Nov 5, 2025
ab680fb
Remove 7.4
VincentLanglet Nov 6, 2025
e982718
Add fail fast
VincentLanglet Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ jobs:
tools: composer:v2
coverage: none

- name: Emulate PHP 8.3
run: composer config platform.php 8.3.999
if: matrix.php == '8.4'

- name: Install PHP dependencies
run: composer update --prefer-dist --no-interaction --no-progress

Expand Down Expand Up @@ -63,6 +59,7 @@ jobs:
name: Symfony ${{ matrix.symfony }} LTS
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- symfony: '4.4.*'
Expand All @@ -71,8 +68,10 @@ jobs:
php-version: '7.4'
- symfony: '6.4.*'
php-version: '8.2'
- symfony: '7.0.*'
php-version: '8.2'
- symfony: '7.3.*'
php-version: '8.3'
Copy link
Contributor

@dbu dbu Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build error might be related to what happens when we use php 8.3 instead of 8.2, or because we require 7.4 instead of 7.0. 7.4 has no stable release yet, do we need to allow dev versions for the 7.4 and 8.0 build?

Copy link
Author

@VincentLanglet VincentLanglet Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why 7.4 fail ; I'll try to remove 7.4 first to see if it works on 8.0 first.

Anyway I discover it will be block by https://github.com/phpspec/phpspec

Copy link
Contributor

@dbu dbu Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i started the build. and thanks for starting phpspec/phpspec#1498, lets hope that can be wrapped up quickly.

the 8.0 build fails because of phpspec.

- symfony: '8.0.*'
php-version: '8.4'

steps:
- name: Checkout code
Expand All @@ -91,7 +90,7 @@ jobs:
run: |
composer global config --no-plugins allow-plugins.symfony/flex true
composer global require --no-progress --no-scripts --no-plugins symfony/flex
composer update --prefer-dist --no-interaction --prefer-stable --no-progress
composer update --prefer-dist --no-interaction --no-progress

- name: Execute tests
run: composer test
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## 2.8.0

- Allow installation with Symfony 8.

## 2.7.2 - 2024-09-24

- Updated code to not raise warnings for nullable parameters in PHP 8.4.
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
"psr/http-client": "^1.0",
"psr/http-factory": "^1.0",
"psr/http-message": "^1.0 || ^2.0",
"symfony/options-resolver": "~4.0.15 || ~4.1.9 || ^4.2.1 || ^5.0 || ^6.0 || ^7.0",
"symfony/options-resolver": "~4.0.15 || ~4.1.9 || ^4.2.1 || ^5.0 || ^6.0 || ^7.0 || ^8.0",
"symfony/polyfill-php80": "^1.17"
},
"require-dev": {
"doctrine/instantiator": "^1.1",
"guzzlehttp/psr7": "^1.4",
"nyholm/psr7": "^1.2",
"phpspec/phpspec": "^5.1 || ^6.3 || ^7.1",
"phpspec/phpspec": "^5.1 || ^6.3 || ^7.1 || ^8.0",
"phpspec/prophecy": "^1.10.2",
"phpunit/phpunit": "^7.5.20 || ^8.5.33 || ^9.6.7"
},
Expand Down
Loading