Skip to content

Conversation

@VincentLanglet
Copy link

@VincentLanglet VincentLanglet commented Nov 5, 2025

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Hi @dbu,
I'm adding support for SF8

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

@dbu dbu changed the title Allow PHP 8 Allow Symfony 8 Nov 6, 2025
@dbu
Copy link
Contributor

dbu commented Nov 6, 2025

thanks for the pull request. i triggered a build and the phpstan error is also happening on 2.x branch: #251

can you check why the LTS build fails? we can drop 4.4 build if that is problematic, but 5.4, 6.4 and 7.4 should still work. from the error it looks like something in the setup for the test is not right when 7.4 fails because 8.0

- symfony: '7.0.*'
php-version: '8.2'
- symfony: '7.4.*'
php-version: '8.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build error might be related to what happens when we use php 8.3 instead of 8.2, or because we require 7.4 instead of 7.0. 7.4 has no stable release yet, do we need to allow dev versions for the 7.4 and 8.0 build?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why 7.4 fail ; I'll try to remove 7.4 first to see if it works on 8.0 first.

Anyway I discover it will be block by https://github.com/phpspec/phpspec

Copy link
Contributor

@dbu dbu Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i started the build. and thanks for starting phpspec/phpspec#1498, lets hope that can be wrapped up quickly.

the 8.0 build fails because of phpspec.

@dbu
Copy link
Contributor

dbu commented Nov 6, 2025

please add fail-fast: false inside the LTS strategy configuration, on the same level as matrix:. then all builds will be run even if one of them fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants