Skip to content

feat(NotificationBadge): add support for plain variant #12139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(NotificationBadge): add support for plain variant #12139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/react-core/src/components/NotificationBadge/NotificationBadge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ import { css } from '@patternfly/react-styles';
export enum NotificationBadgeVariant {
read = 'read',
unread = 'unread',
attention = 'attention'
attention = 'attention',
plain = 'plain'
}

export interface NotificationBadgeProps extends Omit<ButtonProps, 'variant'> {
Expand All @@ -29,7 +30,7 @@ export interface NotificationBadgeProps extends Omit<ButtonProps, 'variant'> {
*/
isExpanded?: boolean;
/** Determines the variant of the notification badge. */
variant?: NotificationBadgeVariant | 'read' | 'unread' | 'attention';
variant?: NotificationBadgeVariant | 'read' | 'unread' | 'attention' | 'plain';
/** Flag indicating whether the notification badge animation should be triggered. Each
* time this prop is true, the animation will be triggered a single time.
*/
Expand All @@ -55,6 +56,8 @@ export const NotificationBadge: React.FunctionComponent<NotificationBadgeProps>
const hasCount = count > 0;
const hasChildren = children !== undefined;
const isAttention = variant === NotificationBadgeVariant.attention;
const isPlain = variant === NotificationBadgeVariant.plain;
const _buttonState = isPlain ? undefined : (variant as 'read' | 'unread' | 'attention');
const notificationIcon = isAttention ? attentionIcon : icon;
let notificationContent: React.ReactNode = null;

Expand All @@ -77,10 +80,10 @@ export const NotificationBadge: React.FunctionComponent<NotificationBadgeProps>

return (
<Button
variant={ButtonVariant.stateful}
variant={isPlain ? ButtonVariant.plain : ButtonVariant.stateful}
className={buttonClassName}
aria-expanded={isExpanded}
state={variant}
state={_buttonState}
isClicked={isExpanded}
icon={notificationIcon}
onAnimationEnd={handleAnimationEnd}
Expand Down
Loading