feat(NotificationBadge): add support for plain variant #12139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://pf-react-pr-12139.surge.sh A11y report: https://pf-react-pr-12139-a11y.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #12066
Currently I've added support for "plain" based on the issue's usage (adding it to the existing
variantprop), but I'm wondering whether this may be better as a separateisPlainflag. Though the NotificationBadge props are not 1:1 with Button's props, so maybe adding it as part of thevariantprop is still fine. LMK if anyone has thoughts or preferences about one method or another.