Skip to content

[AQUA] Use custom model name in deployment #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 5, 2025
Merged

[AQUA] Use custom model name in deployment #1236

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e86c870
added support for custom model name for single MD
agrimk Jul 30, 2025
82893a8
Merge branch 'main' into use_custom_model_name_in_deployment
agrimk Jul 31, 2025
2b7120d
PR review comments
agrimk Aug 1, 2025
6793873
Merge branch 'use_custom_model_name_in_deployment' of github.com:orac…
agrimk Aug 1, 2025
7db3ca8
merge conflicts
agrimk Sep 2, 2025
b902ae5
added container runtime param instead of changing MC display name
agrimk Sep 2, 2025
132802b
added custom model name in user params
agrimk Sep 3, 2025
4ed0220
reverting extra white space
agrimk Sep 3, 2025
ef257ab
Merge branch 'main' into use_custom_model_name_in_deployment
mrDzurb Sep 4, 2025
9d426ba
Merge branch 'main' of github.com:oracle/accelerated-data-science int…
agrimk Sep 4, 2025
6804547
added custom model name in final params
agrimk Sep 4, 2025
99f5a78
Merge branch 'use_custom_model_name_in_deployment' of github.com:orac…
agrimk Sep 4, 2025
ea04433
Enhances the logic
mrDzurb Sep 4, 2025
a9ea2d5
Fixes unit tests
mrDzurb Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ads/aqua/modeldeployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,15 @@ def _create(

# validate user provided params
user_params = env_var.get("PARAMS", UNKNOWN)

if (
create_deployment_details.model_name
and "--served-model-name" not in user_params
):
user_params = f"{user_params} --served-model-name {create_deployment_details.model_name}"
elif "--served-model-name" not in user_params:
user_params = f"{user_params} --served-model-name odsc-llm"
Copy link
Member

@mrDzurb mrDzurb Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the odsc-llm be taken from the container params? I don't think that we want to hardcode this on the ADS side. Also --served-model-name will come from the container config as well, and then the user's params and containers one will be merged using

deployment_params = get_combined_params(config_params, user_params)

Could you double check if the user's defined will not be overwritten with the default one from the container config?

Wouldn't this be enough?

if (
            create_deployment_details.model_name
            and "--served-model-name" not in user_params
        ):
            user_params = f"{user_params} --served-model-name {create_deployment_details.model_name}"


if user_params:
# todo: remove this check in the future version, logic to be moved to container_index
if (
Expand Down
3 changes: 3 additions & 0 deletions ads/aqua/modeldeployment/entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,9 @@ class CreateModelDeploymentDetails(BaseModel):
None, description="The description of the deployment."
)
model_id: Optional[str] = Field(None, description="The model OCID to deploy.")
model_name: Optional[str] = Field(
None, description="The model name specified by user to deploy."
)

models: Optional[List[AquaMultiModelRef]] = Field(
None, description="List of models for multimodel deployment."
Expand Down
Loading