[AQUA] Use custom model name in deployment #1236
Conversation
agrimk
requested review from
VipulMascarenhas,
ahosler,
darenr,
mayoor,
mrDzurb and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
agrimk
changed the title
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
…le/accelerated-data-science into use_custom_model_name_in_deployment
|
📌 Cov diff with main: 📌 Overall coverage: |
ads/aqua/model/model.py
Outdated
| **(defined_tags or {}), | ||
| } | ||
|
|
||
| if display_name: |
There was a problem hiding this comment.
I’m not sure I understand the logic here. I thought we wanted to introduce the model name that would be used for inferencing, but here we’re changing the display name of the MC record.
Could you add more description in the PR explaining what this PR for?
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
| ): | ||
| user_params = f"{user_params} --served-model-name {create_deployment_details.model_name}" | ||
| elif "--served-model-name" not in user_params: | ||
| user_params = f"{user_params} --served-model-name odsc-llm" |
There was a problem hiding this comment.
Can the odsc-llm be taken from the container params? I don't think that we want to hardcode this on the ADS side. Also --served-model-name will come from the container config as well, and then the user's params and containers one will be merged using
deployment_params = get_combined_params(config_params, user_params)
Could you double check if the user's defined will not be overwritten with the default one from the container config?
Wouldn't this be enough?
if (
create_deployment_details.model_name
and "--served-model-name" not in user_params
):
user_params = f"{user_params} --served-model-name {create_deployment_details.model_name}"
|
📌 Cov diff with main: 📌 Overall coverage: |
…o use_custom_model_name_in_deployment
…le/accelerated-data-science into use_custom_model_name_in_deployment
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
changed the title
|
|
||
| if create_deployment_details.model_name: | ||
| # Replace existing --served-model-name argument if present, otherwise add it | ||
| if "--served-model-name" in params: |
There was a problem hiding this comment.
We have helper api to update the parameter in params string and you can do something like this
params_dict = get_params_dict(params)
params_dict.update({"--served-model-name": create_deployment_details.model_name})
params = build_params_string(params_dict)
|
📌 Cov diff with main: 📌 Overall coverage: |
4 participants
Description