Skip to content

CLOUDP-352101: Azure Tagging #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CLOUDP-352101: Azure Tagging #2875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cde450b
move tags to more generic dir
roothorp Nov 7, 2025
31f7326
add tags to azure resource creators
roothorp Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test/helper/cloud/aws/vpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@ package aws

import (
"fmt"
taghelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/ec2"

awshelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/api/aws"
)

func CreateVPC(name, cidr, region string) (string, error) {
Expand All @@ -36,9 +35,9 @@ func CreateVPC(name, cidr, region string) (string, error) {
ResourceType: aws.String(ec2.ResourceTypeVpc),
Tags: []*ec2.Tag{
{Key: aws.String("Name"), Value: aws.String(name)},
{Key: aws.String(awshelper.OwnerEmailTag), Value: aws.String(awshelper.AKOEmail)},
{Key: aws.String(awshelper.CostCenterTag), Value: aws.String(awshelper.AKOCostCenter)},
{Key: aws.String(awshelper.EnvironmentTag), Value: aws.String(awshelper.AKOEnvTest)},
{Key: aws.String(taghelper.OwnerEmailTag), Value: aws.String(taghelper.AKOEmail)},
{Key: aws.String(taghelper.CostCenterTag), Value: aws.String(taghelper.AKOCostCenter)},
{Key: aws.String(taghelper.EnvironmentTag), Value: aws.String(taghelper.AKOEnvTest)},
},
}},
})
Expand Down
6 changes: 5 additions & 1 deletion test/helper/cloud/azure/vpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"context"
"errors"
"fmt"
taghelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper"

"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v2"

Expand Down Expand Up @@ -45,7 +46,10 @@ func CreateVPC(ctx context.Context, vpcName, cidr, region string) (string, error
},
},
Tags: map[string]*string{
"Name": pointer.MakePtr(vpcName),
"Name": pointer.MakePtr(vpcName),
taghelper.OwnerEmailTag: pointer.MakePtr(taghelper.AKOEmail),
taghelper.CostCenterTag: pointer.MakePtr(taghelper.AKOCostCenter),
taghelper.EnvironmentTag: pointer.MakePtr(taghelper.AKOEnvTest),
},
},
nil,
Expand Down
26 changes: 13 additions & 13 deletions test/helper/e2e/actions/cloud/aws.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"encoding/json"
"errors"
"fmt"
taghelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper"
"os"
"strings"
"time"
Expand All @@ -31,7 +32,6 @@ import (
"github.com/onsi/ginkgo/v2/dsl/core"

"github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/pointer"
awshelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/api/aws"
)

type AwsAction struct {
Expand Down Expand Up @@ -86,10 +86,10 @@ func (a *AwsAction) CreateKMS(alias, region, atlasAccountArn, assumedRoleArn str
Origin: aws.String("AWS_KMS"),
Policy: aws.String(policyString),
Tags: []*kms.Tag{
{TagKey: aws.String(awshelper.OwnerTag), TagValue: aws.String(awshelper.AKOTeam)},
{TagKey: aws.String(awshelper.OwnerEmailTag), TagValue: aws.String(awshelper.AKOEmail)},
{TagKey: aws.String(awshelper.CostCenterTag), TagValue: aws.String(awshelper.AKOCostCenter)},
{TagKey: aws.String(awshelper.EnvironmentTag), TagValue: aws.String(awshelper.AKOEnvTest)},
{TagKey: aws.String(taghelper.OwnerTag), TagValue: aws.String(taghelper.AKOTeam)},
{TagKey: aws.String(taghelper.OwnerEmailTag), TagValue: aws.String(taghelper.AKOEmail)},
{TagKey: aws.String(taghelper.CostCenterTag), TagValue: aws.String(taghelper.AKOCostCenter)},
{TagKey: aws.String(taghelper.EnvironmentTag), TagValue: aws.String(taghelper.AKOEnvTest)},
},
})

Expand Down Expand Up @@ -414,10 +414,10 @@ func (a *AwsAction) createVPC(name, cidr, region string) (string, error) {
ResourceType: aws.String(ec2.ResourceTypeVpc),
Tags: []*ec2.Tag{
{Key: aws.String("Name"), Value: aws.String(name)},
{Key: aws.String(awshelper.OwnerTag), Value: aws.String(awshelper.AKOTeam)},
{Key: aws.String(awshelper.OwnerEmailTag), Value: aws.String(awshelper.AKOEmail)},
{Key: aws.String(awshelper.CostCenterTag), Value: aws.String(awshelper.AKOCostCenter)},
{Key: aws.String(awshelper.EnvironmentTag), Value: aws.String(awshelper.AKOEnvTest)},
{Key: aws.String(taghelper.OwnerTag), Value: aws.String(taghelper.AKOTeam)},
{Key: aws.String(taghelper.OwnerEmailTag), Value: aws.String(taghelper.AKOEmail)},
{Key: aws.String(taghelper.CostCenterTag), Value: aws.String(taghelper.AKOCostCenter)},
{Key: aws.String(taghelper.EnvironmentTag), Value: aws.String(taghelper.AKOEnvTest)},
},
}},
}
Expand Down Expand Up @@ -496,10 +496,10 @@ func (a *AwsAction) createSubnet(vpcID, name, cidr, region, az string) (*string,
ResourceType: aws.String(ec2.ResourceTypeSubnet),
Tags: []*ec2.Tag{
{Key: aws.String("Name"), Value: aws.String(name)},
{Key: aws.String(awshelper.OwnerTag), Value: aws.String(awshelper.AKOTeam)},
{Key: aws.String(awshelper.OwnerEmailTag), Value: aws.String(awshelper.AKOEmail)},
{Key: aws.String(awshelper.CostCenterTag), Value: aws.String(awshelper.AKOCostCenter)},
{Key: aws.String(awshelper.EnvironmentTag), Value: aws.String(awshelper.AKOEnvTest)},
{Key: aws.String(taghelper.OwnerTag), Value: aws.String(taghelper.AKOTeam)},
{Key: aws.String(taghelper.OwnerEmailTag), Value: aws.String(taghelper.AKOEmail)},
{Key: aws.String(taghelper.CostCenterTag), Value: aws.String(taghelper.AKOCostCenter)},
{Key: aws.String(taghelper.EnvironmentTag), Value: aws.String(taghelper.AKOEnvTest)},
},
}},
VpcId: aws.String(vpcID),
Expand Down
16 changes: 15 additions & 1 deletion test/helper/e2e/actions/cloud/azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"context"
"errors"
"fmt"
taghelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper"

"github.com/Azure/azure-sdk-for-go/sdk/azcore"
"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
Expand Down Expand Up @@ -141,6 +142,11 @@ func (a *AzureAction) CreatePrivateEndpoint(vpcName, subnetName, endpointName, s
},
},
},
Tags: map[string]*string{
taghelper.OwnerEmailTag: pointer.MakePtr(taghelper.AKOEmail),
taghelper.CostCenterTag: pointer.MakePtr(taghelper.AKOCostCenter),
taghelper.EnvironmentTag: pointer.MakePtr(taghelper.AKOEnvTest),
},
},
nil,
)
Expand Down Expand Up @@ -246,7 +252,10 @@ func (a *AzureAction) createVpcWithSubnets(ctx context.Context, vpcName, cidr, r
Subnets: subnetsSpec,
},
Tags: map[string]*string{
"Name": pointer.MakePtr(vpcName),
"Name": pointer.MakePtr(vpcName),
taghelper.OwnerEmailTag: pointer.MakePtr(taghelper.AKOEmail),
taghelper.CostCenterTag: pointer.MakePtr(taghelper.AKOCostCenter),
taghelper.EnvironmentTag: pointer.MakePtr(taghelper.AKOEnvTest),
},
},
nil,
Expand Down Expand Up @@ -421,6 +430,11 @@ func (a *AzureAction) CreateKeyVault(keyName string) (string, error) {
Properties: &armkeyvault.KeyProperties{
Kty: pointer.MakePtr(armkeyvault.JSONWebKeyTypeRSA),
},
Tags: map[string]*string{
taghelper.OwnerEmailTag: pointer.MakePtr(taghelper.AKOEmail),
taghelper.CostCenterTag: pointer.MakePtr(taghelper.AKOCostCenter),
taghelper.EnvironmentTag: pointer.MakePtr(taghelper.AKOEnvTest),
},
}

r, err := a.keyVaultResourceFactory.NewKeysClient().CreateIfNotExist(ctx, a.resourceGroupName, AzureKeyVaultName, keyName, params, nil)
Expand Down
11 changes: 5 additions & 6 deletions test/helper/e2e/actions/cloudaccess/aws_roles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,12 @@ package cloudaccess

import (
"encoding/json"
taghelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper"
"strings"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/session"
"github.com/aws/aws-sdk-go/service/iam"

awshelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/api/aws"
)

type AssumeRolePolicyDocument struct {
Expand Down Expand Up @@ -105,10 +104,10 @@ func CreateAWSIAMRole(roleName string) (string, error) {
roleInput.SetRoleName(roleName)
roleInput.SetAssumeRolePolicyDocument(policy)
roleInput.Tags = []*iam.Tag{
{Key: aws.String(awshelper.OwnerTag), Value: aws.String(awshelper.AKOTeam)},
{Key: aws.String(awshelper.OwnerEmailTag), Value: aws.String(awshelper.AKOEmail)},
{Key: aws.String(awshelper.CostCenterTag), Value: aws.String(awshelper.AKOCostCenter)},
{Key: aws.String(awshelper.EnvironmentTag), Value: aws.String(awshelper.AKOEnvTest)},
{Key: aws.String(taghelper.OwnerTag), Value: aws.String(taghelper.AKOTeam)},
{Key: aws.String(taghelper.OwnerEmailTag), Value: aws.String(taghelper.AKOEmail)},
{Key: aws.String(taghelper.CostCenterTag), Value: aws.String(taghelper.AKOCostCenter)},
{Key: aws.String(taghelper.EnvironmentTag), Value: aws.String(taghelper.AKOEnvTest)},
}
//roleInput.SetTags([]*iam.Tag{
// {
Expand Down
17 changes: 9 additions & 8 deletions test/helper/e2e/api/aws/aws_resources_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package helper

import (
"fmt"
taghelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/session"
Expand Down Expand Up @@ -104,10 +105,10 @@ func (g *AwsResourcesGenerator) CreatePolicy(name string, policy func() IAMPolic
PolicyDocument: policy(),
PolicyName: aws.String(name),
Tags: []*iam.Tag{
{Key: aws.String(OwnerTag), Value: aws.String(AKOTeam)},
{Key: aws.String(OwnerEmailTag), Value: aws.String(AKOEmail)},
{Key: aws.String(CostCenterTag), Value: aws.String(AKOCostCenter)},
{Key: aws.String(EnvironmentTag), Value: aws.String(AKOEnvTest)},
{Key: aws.String(taghelper.OwnerTag), Value: aws.String(taghelper.AKOTeam)},
{Key: aws.String(taghelper.OwnerEmailTag), Value: aws.String(taghelper.AKOEmail)},
{Key: aws.String(taghelper.CostCenterTag), Value: aws.String(taghelper.AKOCostCenter)},
{Key: aws.String(taghelper.EnvironmentTag), Value: aws.String(taghelper.AKOEnvTest)},
},
}

Expand Down Expand Up @@ -185,10 +186,10 @@ func (g *AwsResourcesGenerator) CreateBucket(name string) error {

tagSet := &s3.Tagging{
TagSet: []*s3.Tag{
{Key: aws.String(OwnerTag), Value: aws.String(AKOTeam)},
{Key: aws.String(OwnerEmailTag), Value: aws.String(AKOEmail)},
{Key: aws.String(CostCenterTag), Value: aws.String(AKOCostCenter)},
{Key: aws.String(EnvironmentTag), Value: aws.String(AKOEnvTest)},
{Key: aws.String(taghelper.OwnerTag), Value: aws.String(taghelper.AKOTeam)},
{Key: aws.String(taghelper.OwnerEmailTag), Value: aws.String(taghelper.AKOEmail)},
{Key: aws.String(taghelper.CostCenterTag), Value: aws.String(taghelper.AKOCostCenter)},
{Key: aws.String(taghelper.EnvironmentTag), Value: aws.String(taghelper.AKOEnvTest)},
},
}

Expand Down
9 changes: 7 additions & 2 deletions test/helper/e2e/api/azure/azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import (
"context"
"errors"
"fmt"
"github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/pointer"
taghelper "github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper"
"path"
"time"

Expand Down Expand Up @@ -63,8 +65,11 @@ func SessionAzure(subscriptionID string, tagNameValue string) (sessionAzure, err
SubscriptionID: subscriptionID,
Authorizer: authorizer,
Tags: map[string]*string{
"name": to.StringPtr(tagNameValue),
config.TagForTestKey: to.StringPtr(config.TagForTestValue),
"name": to.StringPtr(tagNameValue),
config.TagForTestKey: to.StringPtr(config.TagForTestValue),
taghelper.OwnerEmailTag: pointer.MakePtr(taghelper.AKOEmail),
taghelper.CostCenterTag: pointer.MakePtr(taghelper.AKOCostCenter),
taghelper.EnvironmentTag: pointer.MakePtr(taghelper.AKOEnvTest),
},
}, nil
}
Expand Down
0 test/helper/e2e/api/aws/tags.go → test/helper/tags.go
View file
Open in desktop
File renamed without changes.
Loading