Skip to content

Conversation

@roothorp
Copy link
Collaborator

@roothorp roothorp commented Nov 7, 2025

Summary

First pass at tagging azure resources.
Note that there are still static resources in Azure that will need to be tagged manually.

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@roothorp roothorp requested a review from a team as a code owner November 7, 2025 14:27
@josvazg
Copy link
Collaborator

josvazg commented Nov 7, 2025

I like that we try to make the tag definitions common or at leats defined in a single place for all clouds.

I would rename it as simply tags and give it its own package at test/helper/tags/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants