Skip to content

update step focus logic for first launch in Getting Started page #269654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhavyaus wants to merge 2 commits into from
Closed

update step focus logic for first launch in Getting Started page #269654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21f2e10
update step focus logic for first launch in Getting Started page
bhavyaus Oct 3, 2025
7073515
fix smoke test
bhavyaus Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/vs/workbench/contrib/chat/browser/chatWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,6 +1085,9 @@ export class ChatWidget extends Disposable implements IChatWidget {

if (numItems === 0) {
this.refreshHistoryList();
if (!dom.isAncestorOfActiveElement(this.container)) {
this.focusInput();
}
}
}

Expand Down
12 changes: 7 additions & 5 deletions src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ export class GettingStartedPage extends EditorPane {
return '';
}

private async selectStep(id: string | undefined, delayFocus = true) {
private async selectStep(id: string | undefined, delayFocus = true, firstLaunch = false) {
if (id) {
let stepElement = this.container.querySelector<HTMLDivElement>(`[data-step-id="${id}"]`);
if (!stepElement) {
Expand All @@ -782,7 +782,9 @@ export class GettingStartedPage extends EditorPane {
}
}
});
setTimeout(() => (stepElement as HTMLElement).focus(), delayFocus && this.shouldAnimate() ? SLIDE_TRANSITION_TIME_MS : 0);
if (!firstLaunch) {
setTimeout(() => (stepElement as HTMLElement).focus(), delayFocus && this.shouldAnimate() ? SLIDE_TRANSITION_TIME_MS : 0);
}

this.editorInput.selectedStep = id;

Expand Down Expand Up @@ -952,7 +954,7 @@ export class GettingStartedPage extends EditorPane {
this.currentWalkthrough = first;
this.editorInput.selectedCategory = this.currentWalkthrough?.id;
this.editorInput.walkthroughPageTitle = this.currentWalkthrough.walkthroughPageTitle;
this.buildCategorySlide(this.editorInput.selectedCategory, undefined);
this.buildCategorySlide(this.editorInput.selectedCategory, undefined, true /* firstLaunch */);
this.setSlide('details', true /* firstLaunch */);
return;
}
Expand Down Expand Up @@ -1388,7 +1390,7 @@ export class GettingStartedPage extends EditorPane {
super.clearInput();
}

private buildCategorySlide(categoryID: string, selectedStep?: string) {
private buildCategorySlide(categoryID: string, selectedStep?: string, firstLaunch?: boolean) {
if (this.detailsScrollbar) { this.detailsScrollbar.dispose(); }

this.extensionService.whenInstalledExtensionsRegistered().then(() => {
Expand Down Expand Up @@ -1531,7 +1533,7 @@ export class GettingStartedPage extends EditorPane {
reset(this.stepsContent, categoryDescriptorComponent, stepListComponent, this.stepMediaComponent, categoryFooter);

const toExpand = category.steps.find(step => this.contextService.contextMatchesRules(step.when) && !step.done) ?? category.steps[0];
this.selectStep(selectedStep ?? toExpand.id, !selectedStep);
this.selectStep(selectedStep ?? toExpand.id, !selectedStep, firstLaunch);

this.detailsScrollbar.scanDomNode();
this.detailsPageScrollbar?.scanDomNode();
Expand Down
Loading