update step focus logic for first launch in Getting Started page #269654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes step focus logic for first launch in the Getting Started page to prevent unwanted automatic focus behavior during initial application startup.
- Updates the
selectStepmethod to accept afirstLaunchparameter that prevents automatic focus when true - Modifies the category slide building logic to pass the
firstLaunchflag through the call chain - Adds focus input call in chat widget when there are no items
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts | Updates step selection logic to conditionally skip focus behavior on first launch |
| src/vs/workbench/contrib/chat/browser/chatWidget.ts | Adds input focus when chat history is empty |
src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts
Show resolved
Hide resolved
bpasero
previously approved these changes
Oct 3, 2025
bhavyaus
force-pushed
the
dev/bhavyau/welcome-focus
branch
from
58eb512 to
5ed700b
Compare
bhavyaus
force-pushed
the
dev/bhavyau/welcome-focus
branch
from
5ed700b to
21f2e10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #255348