Skip to content

Skip tests that require ffmpeg built with libvpx support also on Win with ffmpeg 8 #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip tests that require ffmpeg built with libvpx support also on Win with ffmpeg 8 #1016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,7 @@ def test_video_encoder_round_trip(self, tmp_path, format, method):
f"FFmpeg6 defaults to lossy encoding for {format}, skipping round-trip test."
)
if format == "webm" and (
ffmpeg_version == 4 or (IS_WINDOWS and ffmpeg_version in (6, 7))
ffmpeg_version == 4 or (IS_WINDOWS and ffmpeg_version in (6, 7, 8))
):
pytest.skip("Codec for webm is not available in this FFmpeg installation.")
source_frames = self.decode(TEST_SRC_2_720P.path).data
Expand Down Expand Up @@ -1234,7 +1234,7 @@ def test_against_to_file(self, tmp_path, format, method):
# Test that to_file, to_tensor, and to_file_like produce the same results
ffmpeg_version = get_ffmpeg_major_version()
if format == "webm" and (
ffmpeg_version == 4 or (IS_WINDOWS and ffmpeg_version in (6, 7))
ffmpeg_version == 4 or (IS_WINDOWS and ffmpeg_version in (6, 7, 8))
):
pytest.skip("Codec for webm is not available in this FFmpeg installation.")

Expand Down Expand Up @@ -1281,7 +1281,7 @@ def test_against_to_file(self, tmp_path, format, method):
def test_video_encoder_against_ffmpeg_cli(self, tmp_path, format):
ffmpeg_version = get_ffmpeg_major_version()
if format == "webm" and (
ffmpeg_version == 4 or (IS_WINDOWS and ffmpeg_version in (6, 7))
ffmpeg_version == 4 or (IS_WINDOWS and ffmpeg_version in (6, 7, 8))
):
pytest.skip("Codec for webm is not available in this FFmpeg installation.")

Expand Down
Loading