Skip tests that require ffmpeg built with libvpx support also on Win with ffmpeg 8 #1016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was obtaining some test failures in conda-forge/torchcodec-feedstock#39, and it seems that some tests required ffmpeg built with libvpx support, to have a vp8 encoder, that is currently not available on Windows due to conda-forge/libvpx-feedstock#6 .
Indeed, it seems that for some reason the related tests were disabled for ffmpeg 6 and 7, while not for ffmpeg 8, even if also ffmpeg 8 on Windows does not have a vp8 encoder. I am not sure why upstream CI is passing, but this patch fixes the tests on conda-forge.