Skip some controller tests in OSS #1830
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86796388. |
Summary: Over a few CI runs we see these tests are occasionally timing out. Put a time bound on these tests, and skip the ones that often run over the time bound to avoid failing the whole job. Differential Revision: D86796388
dulinriley
force-pushed
the
export-D86796388
branch
from
e457b5d to
87766ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Over a few CI runs we see these tests are occasionally timing out. Put a time bound on
these tests, and skip the ones that often run over the time bound to avoid failing the whole
job.
Differential Revision: D86796388