Skip to content

Commit e457b5d

Browse files
dulinrileyfacebook-github-bot
authored andcommitted
Skip some controller tests in OSS
Summary: Over a few CI runs we see these tests are occasionally timing out. Put a time bound on these tests, and skip the ones that often run over the time bound to avoid failing the whole job. Differential Revision: D86796388
1 parent 9f0274a commit e457b5d

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

controller/src/lib.rs

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,9 @@ mod tests {
665665

666666
use super::*;
667667

668-
#[tokio::test]
668+
#[async_timed_test(timeout_secs = 30)]
669+
// TODO: worker messages are 0 instead of 1, or sometimes times out.
670+
#[cfg_attr(not(fbcode_build), ignore)]
669671
async fn basic_controller() {
670672
// TODO: Add a proper multiworker test
671673
let proc = Proc::local();
@@ -856,6 +858,7 @@ mod tests {
856858
);
857859
}
858860

861+
// Can't use async_timed_test because of tokio::time::pause and advance.
859862
#[tokio::test]
860863
async fn worker_timeout() {
861864
tokio::time::pause();
@@ -976,6 +979,7 @@ mod tests {
976979
);
977980
}
978981

982+
// Can't use async_timed_test because of tokio::time::pause and advance.
979983
#[tokio::test]
980984
async fn test_failure_on_worker_timeout() {
981985
tokio::time::pause();
@@ -1113,7 +1117,9 @@ mod tests {
11131117
);
11141118
}
11151119

1116-
#[tokio::test]
1120+
#[async_timed_test(timeout_secs = 30)]
1121+
// TODO: sometimes times out.
1122+
#[cfg_attr(not(fbcode_build), ignore)]
11171123
async fn failure_propagation() {
11181124
// Serve a system.
11191125
let server_handle = System::serve(
@@ -1342,7 +1348,7 @@ mod tests {
13421348
)
13431349
}
13441350

1345-
#[tokio::test]
1351+
#[async_timed_test(timeout_secs = 30)]
13461352
async fn test_eager_failure_reporting() {
13471353
// Serve a system.
13481354
let server_handle = System::serve(
@@ -1515,7 +1521,7 @@ mod tests {
15151521
assert_eq!(successes, 1);
15161522
}
15171523

1518-
#[tokio::test]
1524+
#[async_timed_test(timeout_secs = 30)]
15191525
async fn test_bootstrap() {
15201526
let server_handle = System::serve(
15211527
ChannelAddr::any(ChannelTransport::Local),
@@ -1592,7 +1598,8 @@ mod tests {
15921598
)
15931599
}
15941600

1595-
#[tokio::test]
1601+
#[async_timed_test(timeout_secs = 30)]
1602+
#[cfg_attr(not(fbcode_build), ignore)]
15961603
async fn test_sim_supervision_failure() {
15971604
// Start system actor.
15981605
simnet::start();
@@ -1702,7 +1709,8 @@ mod tests {
17021709
let records = simnet::simnet_handle().unwrap().close().await.unwrap();
17031710
eprintln!("{}", serde_json::to_string_pretty(&records).unwrap());
17041711
}
1705-
#[tokio::test]
1712+
1713+
#[async_timed_test(timeout_secs = 30)]
17061714
async fn test_supervision_failure() {
17071715
// Start system actor.
17081716
let timeout: Duration = Duration::from_secs(6);

0 commit comments

Comments
 (0)