-
Notifications
You must be signed in to change notification settings - Fork 5
Wire up translations #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+786
−72
Closed
Wire up translations #104
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| en_US | ||
| de_DE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| data/xyz.iinuwa.CredentialManager.desktop.in.in | ||
| data/xyz.iinuwa.CredentialManager.gschema.xml.in | ||
| data/xyz.iinuwa.CredentialManager.metainfo.xml.in.in | ||
| data/xyz.iinuwa.credentialsd.CredentialsUi.desktop.in.in | ||
| data/xyz.iinuwa.credentialsd.CredentialsUi.gschema.xml.in | ||
| data/xyz.iinuwa.credentialsd.CredentialsUi.metainfo.xml.in.in | ||
| data/resources/ui/shortcuts.ui | ||
| data/resources/ui/window.ui | ||
| src/application.rs | ||
| src/gui/view_model/gtk/mod.rs | ||
| src/gui/view_model/gtk/device.rs | ||
| src/gui/view_model/mod.rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,218 @@ | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: credentialsd-ui\n" | ||
| "Report-Msgid-Bugs-To: \"https://github.com/linux-credentials/credentialsd/" | ||
| "issues\"\n" | ||
| "POT-Creation-Date: 2025-10-24 08:05+0200\n" | ||
| "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" | ||
| "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n" | ||
| "Language: \n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: 8bit\n" | ||
| "Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n" | ||
|
|
||
| #. Insert your license of choice here | ||
| #. <project_license>LGPL-3.0-only</project_license> | ||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.desktop.in.in:2 | ||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.metainfo.xml.in.in:8 | ||
| #: src/gui/view_model/gtk/mod.rs:372 | ||
| msgid "Credential Manager" | ||
| msgstr "" | ||
|
|
||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.desktop.in.in:3 | ||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.metainfo.xml.in.in:9 | ||
| msgid "Write a GTK + Rust application" | ||
| msgstr "" | ||
|
|
||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.desktop.in.in:9 | ||
| msgid "Gnome;GTK;" | ||
| msgstr "" | ||
|
|
||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.gschema.xml.in:6 | ||
| msgid "Window width" | ||
| msgstr "" | ||
|
|
||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.gschema.xml.in:10 | ||
| msgid "Window height" | ||
| msgstr "" | ||
|
|
||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.gschema.xml.in:14 | ||
| msgid "Window maximized state" | ||
| msgstr "" | ||
|
|
||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.metainfo.xml.in.in:11 | ||
| msgid "" | ||
| "A boilerplate template for GTK + Rust. It uses Meson as a build system and " | ||
| "has flatpak support by default." | ||
| msgstr "" | ||
|
|
||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.metainfo.xml.in.in:16 | ||
| msgid "Registering a credential" | ||
| msgstr "" | ||
|
|
||
| #. developer_name tag deprecated with Appstream 1.0 | ||
| #: data/xyz.iinuwa.credentialsd.CredentialsUi.metainfo.xml.in.in:34 | ||
| msgid "Isaiah Inuwa" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/shortcuts.ui:11 | ||
| msgctxt "shortcut window" | ||
| msgid "General" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/shortcuts.ui:14 | ||
| msgctxt "shortcut window" | ||
| msgid "Show Shortcuts" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/shortcuts.ui:20 | ||
| msgctxt "shortcut window" | ||
| msgid "Quit" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:6 | ||
| msgid "_Preferences" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:10 | ||
| msgid "_Keyboard Shortcuts" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:43 | ||
| msgid "Choose device" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:49 | ||
| msgid "Devices" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:72 | ||
| msgid "Plug in security key" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:113 | ||
| msgid "Scan the QR code to connect your device" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:158 data/resources/ui/window.ui:164 | ||
| msgid "Choose credential" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:187 | ||
| msgid "Complete" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:193 | ||
| msgid "Done!" | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:204 | ||
| msgid "Something went wrong." | ||
| msgstr "" | ||
|
|
||
| #: data/resources/ui/window.ui:217 src/gui/view_model/mod.rs:233 | ||
| msgid "" | ||
| "Something went wrong while retrieving a credential. Please try again later " | ||
| "or use a different authenticator." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:139 | ||
| msgid "Enter your PIN. One attempt remaining." | ||
| msgid_plural "Enter your PIN. %d attempts remaining." | ||
| msgstr[0] "" | ||
| msgstr[1] "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:145 | ||
| msgid "Enter your PIN." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:154 | ||
| msgid "Touch your device again. One attempt remaining." | ||
| msgid_plural "Touch your device again. %d attempts remaining." | ||
| msgstr[0] "" | ||
| msgstr[1] "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:160 | ||
| msgid "Touch your device." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:165 | ||
| msgid "Touch your device" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:168 | ||
| msgid "Scan the QR code with your device to begin authentication." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:178 | ||
| msgid "" | ||
| "Connecting to your device. Make sure both devices are near each other and " | ||
| "have Bluetooth enabled." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:186 | ||
| msgid "Device connected. Follow the instructions on your device" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:312 | ||
| msgid "Insert your security key." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/mod.rs:328 | ||
| msgid "Multiple devices found. Please select with which to proceed." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/device.rs:57 | ||
| msgid "A Bluetooth device" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/device.rs:58 | ||
| msgid "This device" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/device.rs:59 | ||
| msgid "A mobile device" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/device.rs:60 | ||
| msgid "Linked Device" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/device.rs:61 | ||
| msgid "An NFC device" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/gtk/device.rs:62 | ||
| msgid "A security key" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/mod.rs:65 | ||
| msgid "Create new credential" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/mod.rs:66 | ||
| msgid "Use a credential" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/mod.rs:173 | ||
| msgid "Failed to select credential from device." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/mod.rs:227 | ||
| msgid "No matching credentials found on this authenticator." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/mod.rs:230 | ||
| msgid "" | ||
| "No more PIN attempts allowed. Try removing your device and plugging it back " | ||
| "in." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/mod.rs:236 | ||
| msgid "This credential is already registered on this authenticator." | ||
| msgstr "" | ||
|
|
||
| #: src/gui/view_model/mod.rs:284 | ||
| msgid "Something went wrong. Try again later or use a different authenticator." | ||
| msgstr "" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain more about the issue that occurs here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running
meson compile credentialsd-ui-pot, the license-field gets automatically filled withMIT, and one has to manually revert that change back to LGPL, before committing.I have not found a way to tell
gettextto use the correct license here when it auto-generates the file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we skip checking in this file? In another project where we use gettext, we only check in the .po files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, yes. But the .po-files have the same problem with the license-string.
And it may be a tiny bit easier to add new languages with the pot-file there (although that may be debatable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the other project,
msgmergewhich update the .po file doesn't enforce any license on the .po file. I'll try your branch later today and see if I can tame the tools here as well ;)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I looked closer into this. It is actually not any metadata about the project, it's only some surrounding context to help the translator for the next string to translate, "Credential Manager". It's extracted from data/xyz.iinuwa.credentialsd.CredentialsUi.metainfo.xml.in.in so that's where we should change.
I'm not sure if the strings in data/xyz.iinuwa.credentialsd.CredentialsUi.metainfo.xml.in.in are translated in the app so maybe easier to just remove that file from
credentialsd-ui/po/POTFILES.inThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wow. Now that you say it, it's so obvious. 🤦
Thank for digging into that! That file needs to be reworked completely anyways. I'm leaving it in for now.