Skip to content

Fixed new and open (issue 121) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2017
Merged

Fixed new and open (issue 121) #122

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a52997
fix #121 : set `changes` attribute of DataModel and Adapter to an emp…
alixdamman Nov 27, 2017
abebf39
removed meaningless comment above self.current_filter in Adapter.init
alixdamman Nov 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions larray_editor/arrayadapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ def __init__(self, axes_model, xlabels_model, ylabels_model, data_model):
self.data_model = data_model

# these are not valid values, but should overwritten by set_data which must be called before the adapter is used
self.current_filter = None
Copy link
Collaborator

@gdementen gdementen Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the comment above which is no longer true

self.changes = None
self.current_filter = {}
self.changes = {}
self.la_data = None
self.bg_value = None
self.filtered_data = None
Expand Down
2 changes: 1 addition & 1 deletion larray_editor/arraymodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def __init__(self, parent=None, readonly=False, format="%.3f", font=None, minval
self.minvalue = minvalue
self.maxvalue = maxvalue

self.changes = None
self.changes = {}
self.color_func = None

self.vmin = None
Expand Down