Fixed new and open (issue 121)
#122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pter to an empty dict by default. Methods `new` and `open` in MappingEditor failed because Adapter.update_changes() was called before attribute changes was set (and so was equal to None).
alixdamman
force-pushed
the
fix_file_menu_121
branch
from
633db79 to
0a52997
Compare
gdementen
requested changes
Nov 27, 2017
| self.data_model = data_model | ||
|
|
||
| # these are not valid values, but should overwritten by set_data which must be called before the adapter is used | ||
| self.current_filter = None |
Collaborator
There was a problem hiding this comment.
need to update the comment above which is no longer true
gdementen
approved these changes
Nov 27, 2017
Collaborator
|
Thanks for fixing my mess... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.