Upgrade rubocop to version 1.22.0 #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.83.0 → ~> 1.22.0) · Repo · Changelog
Release Notes
1.22.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 71 commits:
Cut 1.22.0Fix a changelog entryUpdate Changelog[Fix #10135] Fix `Style/WordArray` to exclude files in `--auto-gen-config` when `percent` style is given but brackets are required.Merge pull request #10139 from dvandersluis/issue/10134[Fix #10134] Update `Style/MutableConstant` to not consider multiline uninterpolated strings as unfrozen in ruby 3.0.Merge pull request #10137 from dvandersluis/issue/10136[Fix #10136] Update `Lint/AssignmentInCondition` to not consider assignments within blocks in conditions.Update the message for `Style/OptionalBooleanParameter`.Merge pull request #9961 from lilisako/fix-shadow-variable-in-rescued-exceptions-variable-nameAdd new `Security/IoMethods` copFix a typoAdd spell checking GitHub Actions workflowMinor refactor of `Style/RedundantSort`.Update `Style/RedundantSort` to be unsafe.Revert changes from #10061.Replace `Cop` with `Base` in tests to prepare for deprecating `Cop`.Reorganize RuboCop help into sections for better clarity.Fix new `Style/SelectByRegexp` offenses.Update `Style/SelectByRegexp` to handle `numblock`s.[Fix #8327] Add new `Style/SelectByRegexp` cop.[Fix #9588] Fix causing a variable to be shadowed from outside the rescue blockMerge pull request #10124 from dvandersluis/fix/redundant-line-breakMerge pull request #10131 from dvandersluis/issue/10130[Fix #10130] Update `Lint/ElseLayout` to be able to handle an `else` with only a single line.Corrected Layout/SpaceInsideParens compact style documentationImplemented left compaction for SpaceInsideParens Compact styleImplemented Layout/SpaceInsideParens with EnforcedStyle: compactCorrect new `Layout/RedundantLineBreak` offenses.Add new Style/NumberedParameters cop[Fix #9934] Fix configuration loading to not raise an error for an obsolete ruby version that is subsequently overridden.[Fix #10106] Fix `Style/RedundantSelf` for pattern matching.Add new `Style/NumberedParametersLimit` cop.Merge pull request #10119 from dvandersluis/issue/10118Merge pull request #10123 from dvandersluis/update-gem-cops-baseTweak offense highlight range for `Style/RedundantFileExtensionInRequire`Fix `Layout/RedundantLineBreak` adding extra space within method chains.Use `Cop::Base` for `Bundler/OrderedGems` and `Gemspec/OrderedDependencies`.Merge pull request #10121 from dvandersluis/lint/require-relative-self-pathFix false positive for `Lint/RequireRelativeSelfPath` when requiring a file with the same name but different extension.[Fix #10118] Fix crash with `Style/RedundantSort` when the block doesn't only contain a single `send` node.Merge pull request #10109 from dvandersluis/update-new-cop-instructionsMerge pull request #10113 from dvandersluis/issue/10110[Fix #10110] Update `Layout/DotPosition` to be able to handle heredocs.Update the `rake new_cop` instructions for changelogs.Bump RuboCop Rspec to 2.5Merge pull request #10099 from casperisfine/fix-redundant-freezeMerge pull request #10107 from ngoral/typo_in_block_parameter_name_docTypo in docs for config option for Naming/BlockParameterName`Style/RedundantFreeze` stop considering `ENV` values as immutable[Fix #10103] Add `AllowHttpProtocol` option to `Bundler/InsecureProtocolSource`Merge pull request #10101 from dvandersluis/issue/10096[Fix #10096] Fix `Lint/AmbiguousOperatorPrecedence` with `and`/`or` operators.[Fix #8431] Add `@safety` section to all cops that are `Safe: false` or `SafeAutoCorrect: false`.Allow safety information to be added to cop descriptions.Enable `Lint/BooleanSymbol` copMerge pull request #10091 from koic/fix_false_negative_for_style_arguments_forwardingMerge pull request #10088 from dvandersluis/boolean-symbolUpdate `Lint/BooleanSymbol` to be `SafeAutoCorrect: false` rather than `Safe: false`.[Fix #10090] Fix a false negative for `Style/ArgumentsForwarding`[Fix #10084] Add new `Lint/RequireRelativeSelfPath` copUpdate the documentation for `Lint/BinaryOperatorWithIdenticalOperands` to mention the operators that are ignored.Merge pull request #10086 from dvandersluis/expect-no-correctionsGuard against `expect_corrections` with no changes.Migrate ABC size doc from Markdown to AsciiDoc for AntoraFix confusing test in case_indentation_spec.rb[Docs] Interpreting ABCSize (#10076)[Fix #10066] Fix how `MinDigits` is calculated for `Style/NumericLiterals` when generating a configuration file.Merge pull request #10078 from dvandersluis/layout/line-length-without-directiveFix `Layout/LineLength` reported length when ignoring directive comments.Switch back the docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands