Upgrade rubocop to version 1.21.0 #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.83.0 → ~> 1.21.0) · Repo · Changelog
Release Notes
1.21.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 27 commits:
Cut 1.21Update Changelog[Fix #9061] Add new `Lint/IncompatibleIoSelectWithFiberScheduler` copUpdate `Naming/InclusiveLanguage` to be disabled by default.[Fix #10070] Fix a false positive for `Style/MutableConstant`Mark `Style/AndOr` as unsafe auto-correctionFix an error for `Lint/NumberConversion`Merge pull request #10064 from casperisfine/explicit-block-correctorStyle/ExplicitBlockArgument: do not assume the block parameter nameMerge pull request #10063 from koic/fix_a_false_positive_for_layout_single_line_block_chainRemove redundant `AutoCorrect` config of `Layout/LineLength`Fix a false positive for `Layout/SingleLineBlockChain`Use `RESTRICT_ON_SEND`[Fix #10061] Fix a false positive for `Style/RedundantSort`Fix a build errorFix a false positive for `Layout/SpaceAroundOperators`Correct `Lint/AmbiguousOperatorPrecedence` offenses.[Fix #7849] Add new `Lint/AmbiguousOperatorPrecedence` cop.Restyle example formatting for `Style/CaseEquality`Merge pull request #10053 from neoeno/patch-1Improve grammar in Bundler/InsecureProtocolSource docsMerge pull request #10051 from dvandersluis/style/documentationImprove the messaging for `Style/Documentation` to be more clear about what class/module needs documentation.Remove a redundant empty `RESTRICT_ON_SEND`Merge pull request #10045 from dvandersluis/issue/9674[Fix #9674] Disable `Style/AsciiComments` by default.Switch back docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands