Skip to content

Conversation

@bmccann-bdai
Copy link
Collaborator

Description

Add gnureadline to the base image. Fix up arrow capture in the python REPL.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 14, 2025

Greptile Overview

Greptile Summary

This PR adds the gnureadline Python package to the base Docker image to improve Python REPL usability by enabling proper arrow key handling for command history navigation.

  • Added gnureadline to the pip install command on line 61 of docker/Dockerfile.base
  • The package is installed alongside the existing toml dependency using the Isaac Lab installation script
  • This is a quality-of-life improvement that fixes up arrow key capture in the Python REPL environment within the Docker container

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is minimal, well-scoped, and adds a standard Python package (gnureadline) that improves developer experience without affecting any runtime behavior or introducing dependencies conflicts. The package is widely used and maintains backward compatibility.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
docker/Dockerfile.base 5/5 Added gnureadline to pip install command alongside toml to improve Python REPL arrow key handling

Sequence Diagram

sequenceDiagram
    participant DockerBuild as Docker Build Process
    participant BaseImage as Isaac Sim Base Image
    participant IsaacLabSetup as Isaac Lab Setup
    participant PipInstall as pip install
    participant REPL as Python REPL

    DockerBuild->>BaseImage: FROM isaac-sim base image
    DockerBuild->>IsaacLabSetup: Copy Isaac Lab files
    DockerBuild->>IsaacLabSetup: Set execute permissions on isaaclab.sh
    DockerBuild->>IsaacLabSetup: Create symlink to Isaac Sim
    DockerBuild->>PipInstall: isaaclab.sh -p -m pip install toml gnureadline
    PipInstall->>PipInstall: Install toml package
    PipInstall->>PipInstall: Install gnureadline package
    PipInstall-->>IsaacLabSetup: Dependencies installed
    DockerBuild->>IsaacLabSetup: Install extension apt dependencies
    DockerBuild->>IsaacLabSetup: Create directories for singularity
    DockerBuild->>IsaacLabSetup: Install Isaac Lab dependencies
    DockerBuild->>IsaacLabSetup: Configure bash aliases
    Note over REPL: gnureadline enables proper<br/>arrow key handling in Python REPL
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add license for this dependency?

@Mayankm96 Mayankm96 changed the title Add gnureadline to base image Adds gnureadline to base docker image Nov 19, 2025
@Mayankm96 Mayankm96 moved this to In review in Isaac Lab Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants