-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Adds gnureadline to base docker image #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryThis PR adds the
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant DockerBuild as Docker Build Process
participant BaseImage as Isaac Sim Base Image
participant IsaacLabSetup as Isaac Lab Setup
participant PipInstall as pip install
participant REPL as Python REPL
DockerBuild->>BaseImage: FROM isaac-sim base image
DockerBuild->>IsaacLabSetup: Copy Isaac Lab files
DockerBuild->>IsaacLabSetup: Set execute permissions on isaaclab.sh
DockerBuild->>IsaacLabSetup: Create symlink to Isaac Sim
DockerBuild->>PipInstall: isaaclab.sh -p -m pip install toml gnureadline
PipInstall->>PipInstall: Install toml package
PipInstall->>PipInstall: Install gnureadline package
PipInstall-->>IsaacLabSetup: Dependencies installed
DockerBuild->>IsaacLabSetup: Install extension apt dependencies
DockerBuild->>IsaacLabSetup: Create directories for singularity
DockerBuild->>IsaacLabSetup: Install Isaac Lab dependencies
DockerBuild->>IsaacLabSetup: Configure bash aliases
Note over REPL: gnureadline enables proper<br/>arrow key handling in Python REPL
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Mayankm96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add license for this dependency?
Description
Add gnureadline to the base image. Fix up arrow capture in the python REPL.