Skip to content

feat(select-modal): add select default modal styling for ionic theme #30771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

feat(select-modal): add select default modal styling for ionic theme #30771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64a4ffe
feat(select-modal): add ionic select default modal styling
joselrio Nov 6, 2025
2e73d89
fix(select-modal): typo
joselrio Nov 6, 2025
088eb51
fix(select-modal): run lint
joselrio Nov 6, 2025
22c6e7e
Merge branch 'next' into ROU-12159
joselrio Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/src/components/modal/modal.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@
--border-radius: #{globals.$ion-border-radius-0};
}

// Default Modal
// --------------------------------------------------

// Modal when inside a select default-modal
:host(.select-modal.modal-default) {
--max-height: 45%;
--max-width: calc(100% - (#{globals.$ion-space-400} * 2));
--min-height: 340px;
}
Comment on lines +34 to +38
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be using tokens here? I didn't found them in Figma, but was it checked with the UX Team?

Copy link
Contributor Author

@joselrio joselrio Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be using tokens here? I didn't found them in Figma, but was it checked with the UX Team?

@OS-giulianasilva well, I did not use them because they are not there :P
--max-width is making usage of it. Will ask about others.


// Sheet Modal
// --------------------------------------------------

Expand Down
4 changes: 4 additions & 0 deletions core/src/components/select-modal/select-modal.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
// Ionic Select Modal
// --------------------------------------------------

:host(.in-modal-default) ion-content::part(scroll) {
--padding-bottom: #{globals.$ion-space-400};
}

// Item
// ----------------------------------------------------------------

Expand Down
17 changes: 15 additions & 2 deletions core/src/components/select-modal/select-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { getIonMode } from '@global/ionic-global';
import type { ComponentInterface } from '@stencil/core';
import { Component, Element, Host, Prop, forceUpdate, h } from '@stencil/core';
import { safeCall } from '@utils/overlays';
import { getClassMap } from '@utils/theme';
import { getClassMap, hostContext } from '@utils/theme';

import type { CheckboxCustomEvent } from '../checkbox/checkbox-interface';
import type { RadioGroupCustomEvent } from '../radio-group/radio-group-interface';
Expand Down Expand Up @@ -74,6 +74,14 @@ export class SelectModal implements ComponentInterface {
}
}

private getModalContextClasses() {
const el = this.el;
return {
'in-modal-default': hostContext('ion-modal.modal-default', el),
'in-modal-sheet': hostContext('ion-modal.modal-sheet', el),
};
}

private renderRadioOptions() {
const checked = this.options.filter((o) => o.checked).map((o) => o.value)[0];

Expand Down Expand Up @@ -143,7 +151,12 @@ export class SelectModal implements ComponentInterface {

render() {
return (
<Host class={getIonMode(this)}>
<Host
class={{
[getIonMode(this)]: true,
...this.getModalContextClasses(),
}}
>
<ion-header>
<ion-toolbar>
{this.header !== undefined && <ion-title>{this.header}</ion-title>}
Expand Down
Loading