feat(select-modal): add select default modal styling for ionic theme #30771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joselrio
added
the
type: feature request
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Comment on lines
+34
to
+38
| :host(.select-modal.modal-default) { | ||
| --max-height: 45%; | ||
| --max-width: calc(100% - (#{globals.$ion-space-400} * 2)); | ||
| --min-height: 340px; | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't we be using tokens here? I didn't found them in Figma, but was it checked with the UX Team?
Contributor
Author
There was a problem hiding this comment.
Shouldn't we be using tokens here? I didn't found them in Figma, but was it checked with the UX Team?
@OS-giulianasilva well, I did not use them because they are not there :P
--max-width is making usage of it. Will ask about others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
What is the current behavior?
Once IonSelect was using a modal-default (with no breakpoints) the styling of the modal do not fit with the expected ones for ionic theme.
What is the new behavior?
Under the same context new styling has been added.
Does this introduce a breaking change?