IBX-10879: Deepl: Backoffice shows `InvalidLanguageCodeException´ for unsupported languages #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or unsupported languages
vidarl
force-pushed
the
IBX-10879__Deepl_Backoffice_shows_InvalidLanguageCodeException_for_unsupported_languages
branch
from
7022c49 to
57ec6bc
Compare
…lation" dialog takes supported languages into account
vidarl
force-pushed
the
IBX-10879__Deepl_Backoffice_shows_InvalidLanguageCodeException_for_unsupported_languages
branch
from
57ec6bc to
5e6a992
Compare
Author
|
@dew326 : PR created as we discussed on Friday. JS code for enabling/disabling option in drop-down is missing |
… when being enabled/disabled
vidarl
force-pushed
the
IBX-10879__Deepl_Backoffice_shows_InvalidLanguageCodeException_for_unsupported_languages
branch
from
5e6a992 to
0b56d1e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, admin-ui throws exception if you have languages not supported by the translation client (like DeepL)
I have also changed so that the "Create a new translation" dialog adapts to which languages are supported by translation client:
Here, the checkbox is disabled if any of the languages selected (source or target language) are unsupported
However, there is a problem if you have multiple translation clients configured. Then the checkbox is replaced with a drop-down. However, the current drop-down component doesn't support enabling/disabling options at run-time. Therefore I agreed with @dew326 to commit this PR as is and let the front-end team address that:
Don't be confused by the fact that drop down only contains one client (Deepl). I only have DeepL, so just forced the use of drop-down anyway. The point is that it is not possible to disable the "DeepL" option in a convenient way when an unsupported language is selected.
For QA:
Documentation: