feat: make mqs infra provisioning configurable #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 12, 2025
fmvilas
reviewed
Nov 12, 2025
fmvilas
left a comment
fmvilas
left a comment
There was a problem hiding this comment.
Suggesting an alternative name. Still looking at the code though.
| | `LOG_MAX_CONCURRENCY` | Maximum number of log writing operations to process concurrently. | `1` | No | | ||
| | `MAX_DESTINATIONS_PER_TENANT` | Maximum number of destinations allowed per tenant/organization. | `20` | No | | ||
| | `MAX_RETRY_LIMIT` | Maximum number of retry attempts for a single event delivery before giving up. Ignored if retry_schedule is provided. | `10` | No | | ||
| | `MQS_SHOULD_MANAGE` | Whether Outpost should create and manage message queue infrastructure. Set to false if you manage infrastructure externally (e.g., via Terraform). Defaults to true for backward compatibility. | `nil` | No | |
There was a problem hiding this comment.
What about this?
Suggested change
| | `MQS_SHOULD_MANAGE` | Whether Outpost should create and manage message queue infrastructure. Set to false if you manage infrastructure externally (e.g., via Terraform). Defaults to true for backward compatibility. | `nil` | No | | |
| | `MQS_AUTO_CREATE` | Whether Outpost should create and manage message queue infrastructure. Set to false if you manage infrastructure externally (e.g., via Terraform). Defaults to true for backward compatibility. | `nil` | No | |
Or this?
Suggested change
| | `MQS_SHOULD_MANAGE` | Whether Outpost should create and manage message queue infrastructure. Set to false if you manage infrastructure externally (e.g., via Terraform). Defaults to true for backward compatibility. | `nil` | No | | |
| | `MQS_AUTO_MANAGE` | Whether Outpost should create and manage message queue infrastructure. Set to false if you manage infrastructure externally (e.g., via Terraform). Defaults to true for backward compatibility. | `nil` | No | |
There was a problem hiding this comment.
Or even this?
Suggested change
| | `MQS_SHOULD_MANAGE` | Whether Outpost should create and manage message queue infrastructure. Set to false if you manage infrastructure externally (e.g., via Terraform). Defaults to true for backward compatibility. | `nil` | No | | |
| | `MQS_AUTO_PROVISION` | Whether Outpost should create and manage message queue infrastructure. Set to false if you manage infrastructure externally (e.g., via Terraform). Defaults to true for backward compatibility. | `nil` | No | |
fmvilas
approved these changes
Nov 12, 2025
fmvilas
left a comment
fmvilas
left a comment
There was a problem hiding this comment.
Love this refactor, @alexluong 👏
It makes things way more readable now. You can't imagine how much I appreciate this being new with this codebase 😄 🙏
Comment on lines
+43
to
+48
| if err := a.PreRun(ctx); err != nil { | ||
| return err | ||
| } | ||
| defer a.PostRun(ctx) | ||
|
|
||
| return a.run(ctx) |
There was a problem hiding this comment.
Love this new lifecycle separation. Looks much cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #547
introduces
MQS_SHOULD_MANAGEenvironment variable (open to changing to a better naming convention) which allows users to self-manage the mqs infra themselves