-
Notifications
You must be signed in to change notification settings - Fork 51
Partially automate release - release branch creation and version updates [DI-669] #1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…tes [DI-669] _Partially_ automates the steps listed in [the `C++ Client Release Process` documentation](https://hazelcast.atlassian.net/wiki/spaces/HZC/pages/129810774/C+Client+Release+Process). Specifically, steps: - `Create branch` - `Update next version` By scripting and chaining the steps, the (manual) release work is reduced and consistency is improved. Testing (in my fork): - [example execution](https://github.com/JackPGreen/hazelcast-cpp-client/actions/runs/19166496611) - [branch created](https://github.com/JackPGreen/hazelcast-cpp-client/tree/5.5.0) - [version update PR raised](#5) Post-merge actions: - [ ] update docs _Partially addresses_: [DI-669](https://hazelcast.atlassian.net/browse/DI-669)
nishaatr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from my side
if we keep using PR its fine but still would prefer direct push
I'll raise on the standup next week. It's probably a wider issue than the C++ client. |
| git push origin ${{ steps.project_version.outputs.version }} | ||
|
|
||
| update-version: | ||
| name: Update version in `${{ inputs.BRANCH_NAME }}` to `${{ inputs.NEW_VERSION }}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| name: Update version in `${{ inputs.BRANCH_NAME }}` to `${{ inputs.NEW_VERSION }}` | |
| name: Set next development version in `${{ inputs.BRANCH_NAME }}` to `${{ inputs.NEW_VERSION }}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the issue is with how it was?
Co-authored-by: Łukasz Dziedziul <l.dziedziul@gmail.com>
nishaatr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…streview-3441986352
nishaatr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to mention about maintenance branch
here it says create z-branch
wondering if z-branch is actually used or how frequently! may be no need
…streview-3452919662
| inputs: | ||
| SOURCE_BRANCH_NAME: | ||
| description: The source branch to create a release branch from | ||
| required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can make the default to be master for convenience.
| TARGET_BRANCH_NAME: | ||
| description: The target branch to create - optional, otherwise derived from the version in the source branch | ||
| required: false | ||
| NEW_VERSION_TO_UPDATE_SOURCE_BRANCH_TO: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be the same as TARGET_BRANCH_NAME, right?


Partially automates the steps listed in the
C++ Client Release Processdocumentation.Specifically, steps:
Create branchUpdate next versionBy scripting and chaining the steps, the (manual) release work is reduced and consistency is improved.
Testing (in my fork):
master, it's not actually in the PR)Post-merge actions:
Partially addresses: DI-669