De-duplicate version numbers in CMakeLists.txt [DI-669]
#1363
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than duplicating the version number between client and `examples`, we should simply _inherit_ the version number in `examples` - it's not built on it's own. This is a _step towards_ having the version number declared _only once_ to make incrementing easier.
Contributor
Author
|
We can update the version numbers in all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than duplicating the version number between client and
examples, we should simply inherit the version number inexamples- it's not built on it's own.This is a step towards having the version number declared only once to make incrementing easier.
Partially addresses: DI-669