Skip to content

fix(types): Add None check for projectId in installation external requests #103024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(types): Add None check for projectId in installation external requests #103024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/sentry/sentry_apps/api/endpoints/installation_external_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,15 @@ class SentryAppInstallationExternalRequestsEndpoint(SentryAppInstallationBaseEnd
}

def get(self, request: Request, installation) -> Response:
try:
project = Project.objects.get(
id=request.GET.get("projectId"), organization_id=installation.organization_id
)
except Project.DoesNotExist:
project = None
project_id = request.GET.get("projectId")
project = None
if project_id:
try:
project = Project.objects.get(
id=project_id, organization_id=installation.organization_id
)
except Project.DoesNotExist:
pass

kwargs = {
"install": installation,
Expand Down
Loading