Skip to content

Conversation

@JoshFerge
Copy link
Member

Summary

Validate projectId before querying to handle the case where it's not provided in the request.

Changes

  • Extract project_id from request.GET
  • Add None check before querying Project model
  • Set project to None if projectId is missing or project doesn't exist

Test plan

  • Existing tests pass
  • Mypy type checking passes

…uests

Validate projectId before querying to handle the case where it's not
provided in the request.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ps/api/endpoints/installation_external_requests.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #103024      +/-   ##
===========================================
- Coverage   80.75%    80.64%   -0.11%     
===========================================
  Files        9145      9140       -5     
  Lines      395020    392796    -2224     
  Branches    24968     24968              
===========================================
- Hits       319002    316777    -2225     
- Misses      75617     75618       +1     
  Partials      401       401              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants