-
-
Notifications
You must be signed in to change notification settings - Fork 227
Deprecate Sentry.Azure.Functions.Worker #4693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version6 #4693 +/- ##
===========================================
Coverage ? 73.55%
===========================================
Files ? 474
Lines ? 17306
Branches ? 3418
===========================================
Hits ? 12729
Misses ? 3734
Partials ? 843 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Always-Throwing Sample Blocks OpenTelemetry Demo
The code calls BadApple.HttpScenario() on line 19, which always throws an exception. This means the subsequent lines (21-23) that write the response and return it will never execute. The function will always fail with an unhandled exception rather than demonstrating successful OpenTelemetry integration. This appears to be leftover sample code that should demonstrate error handling, but the exception should be caught or the code should have a conditional path to demonstrate both success and error scenarios.
samples/Sentry.Samples.OpenTelemetry.AzureFunctions/SampleHttpTrigger.cs#L18-L23
sentry-dotnet/samples/Sentry.Samples.OpenTelemetry.AzureFunctions/SampleHttpTrigger.cs
Lines 18 to 23 in 08a0fc2
| BadApple.HttpScenario(); | |
| await response.WriteStringAsync("Welcome to Azure Functions!"); | |
| return response; |
Resolves #4514 :
The functionality for
Sentry.Azure.Functions.Workeris largely redundant as it can easily be replaced by the OpenTelemetry instrumentation that ships with Azure Functions (and which we can capture via our Open Telemetry integration). As such, we've replaced our integration with a sample showing how to do this using our Open Telemetry package instead.