Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

Resolves #4514 :

The functionality for Sentry.Azure.Functions.Worker is largely redundant as it can easily be replaced by the OpenTelemetry instrumentation that ships with Azure Functions (and which we can capture via our Open Telemetry integration). As such, we've replaced our integration with a sample showing how to do this using our Open Telemetry package instead.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (version6@6a67f5e). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             version6    #4693   +/-   ##
===========================================
  Coverage            ?   73.55%           
===========================================
  Files               ?      474           
  Lines               ?    17306           
  Branches            ?     3418           
===========================================
  Hits                ?    12729           
  Misses              ?     3734           
  Partials            ?      843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell jamescrosswell marked this pull request as ready for review November 5, 2025 07:04
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Always-Throwing Sample Blocks OpenTelemetry Demo

The code calls BadApple.HttpScenario() on line 19, which always throws an exception. This means the subsequent lines (21-23) that write the response and return it will never execute. The function will always fail with an unhandled exception rather than demonstrating successful OpenTelemetry integration. This appears to be leftover sample code that should demonstrate error handling, but the exception should be caught or the code should have a conditional path to demonstrate both success and error scenarios.

samples/Sentry.Samples.OpenTelemetry.AzureFunctions/SampleHttpTrigger.cs#L18-L23

BadApple.HttpScenario();
await response.WriteStringAsync("Welcome to Azure Functions!");
return response;

Fix in Cursor Fix in Web


@jamescrosswell jamescrosswell linked an issue Nov 12, 2025 that may be closed by this pull request
@Flash0ver Flash0ver changed the title Depricate Sentry.Azure.Functions.Worker Deprecate Sentry.Azure.Functions.Worker Nov 12, 2025
@jamescrosswell jamescrosswell merged commit f5e906e into version6 Nov 12, 2025
100 of 105 checks passed
@jamescrosswell jamescrosswell deleted the depricate-functions-worker branch November 12, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate Sentry.Azure.Functions.Worker

3 participants