-
Notifications
You must be signed in to change notification settings - Fork 75
DRAFT: Add new rule C#-FriendlyAsyncOverload #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
DRAFT: Add new rule C#-FriendlyAsyncOverload #586
Conversation
|
This PR needs to change because we're going to change the convention: instead of having |
0a6261e to
70d721f
Compare
|
Not all the libraries are meant for C# use. For example type-providers, they just don't work in C#. |
Good point, that's why this rule won't be enabled by default. |
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
Fixes #517
NOTE: this PR supersedes an older PR