CSharpFriendlyAsyncOverload: fix failing tests

Author: parhamsaremi

src/FSharpLint.Core/Rules/Conventions/CSharpFriendlyAsyncOverload.fs

@@ -18,6 +18,13 @@ let rec private getIdentFromSynPat =
         |> Some
     | SynPat.Typed (pat, _, _) -> getIdentFromSynPat pat
     | _ -> None
+    
+let getErrorMessage (ident: string) (range: range) =
+    { Range = range
+      Message = String.Format(Resources.GetString "RulesCSharpFriendlyAsyncOverload", ident)
+      SuggestedFix = None
+      TypeChecks = List.Empty }
+    |> Array.singleton
 
 let runner (args: AstNodeRuleParams) =
     let hasAsync (syntaxArray: array<AbstractSyntaxArray.Node>) nodeIndex fnIdent =
@@ -46,14 +53,13 @@ let runner (args: AstNodeRuleParams) =
                 let idents = getIdentFromSynPat pattern
                 match idents with
                 | Some ident when not (ident.EndsWith "Async") ->
-                    match hasAsync args.SyntaxArray args.NodeIndex ident with
-                    | Some _ -> Array.empty
-                    | None ->
-                        { Range = range
-                          Message = String.Format(Resources.GetString "RulesCSharpFriendlyAsyncOverload", ident)
-                          SuggestedFix = None
-                          TypeChecks = List.Empty }
-                        |> Array.singleton
+                    if (ident.StartsWith "Async") then
+                        match hasAsync args.SyntaxArray args.NodeIndex (ident.Replace("Async", "", StringComparison.Ordinal)) with
+                        | Some _ -> Array.empty
+                        | None ->
+                            getErrorMessage ident range
+                    else
+                        getErrorMessage ident range
                 | _ -> Array.empty
             | _ -> Array.empty
         | _ -> Array.empty

src/FSharpLint.Core/Text.resx

@@ -346,6 +346,6 @@
     <value>Consider using 'Array.empty' instead.</value>
   </data>
   <data name="RulesCSharpFriendlyAsyncOverload" xml:space="preserve">
-    <value>Consider using a C#-friendly async overload for {0}.</value>
+    <value>Async functions in F# should have the "Async" prefix and a C# friendly overload. Check these conventions for {0}.</value>
   </data>
 </root>