Skip to content

fix(ai): Fix generateContentStream returning wrong inferenceSource. #9381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+39 −3
Open

fix(ai): Fix generateContentStream returning wrong inferenceSource. #9381

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9dd3a59
Fix `generateContentStream` returning wrong inferenceSource.
hsubox76 Nov 13, 2025
aa73fa5
add tests
hsubox76 Nov 13, 2025
b1e8f1d
remove old todo
hsubox76 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-rice-carry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/ai': patch
---

Fix `generateContentStream` returning wrong `inferenceSource`.
31 changes: 29 additions & 2 deletions packages/ai/src/methods/generate-content.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
import * as request from '../requests/request';
import {
generateContent,
generateContentStream,
templateGenerateContent,
templateGenerateContentStream
} from './generate-content';
Expand All @@ -35,6 +36,7 @@ import {
HarmBlockMethod,
HarmBlockThreshold,
HarmCategory,
InferenceSource,
Language,
Outcome
} from '../types';
Expand Down Expand Up @@ -548,8 +550,7 @@ describe('generateContent()', () => {
);
});
});
// TODO: define a similar test for generateContentStream
it('on-device', async () => {
it('generateContent on-device', async () => {
const chromeAdapter = fakeChromeAdapter;
const isAvailableStub = stub(chromeAdapter, 'isAvailable').resolves(true);
const mockResponse = getMockResponse(
Expand All @@ -566,9 +567,35 @@ describe('generateContent()', () => {
chromeAdapter
);
expect(result.response.text()).to.include('Mountain View, California');
expect(result.response.inferenceSource).to.equal(InferenceSource.ON_DEVICE);
expect(isAvailableStub).to.be.called;
expect(generateContentStub).to.be.calledWith(fakeRequestParams);
});
it('generateContentStream on-device', async () => {
const chromeAdapter = fakeChromeAdapter;
const isAvailableStub = stub(chromeAdapter, 'isAvailable').resolves(true);
const mockResponse = getMockResponseStreaming(
'vertexAI',
'streaming-success-basic-reply-short.txt'
);
const generateContentStreamStub = stub(
chromeAdapter,
'generateContentStream'
).resolves(mockResponse as Response);
const result = await generateContentStream(
fakeApiSettings,
'model',
fakeRequestParams,
chromeAdapter
);
const aggregatedResponse = await result.response;
expect(aggregatedResponse.text()).to.include('Cheyenne');
expect(aggregatedResponse.inferenceSource).to.equal(
InferenceSource.ON_DEVICE
);
expect(isAvailableStub).to.be.called;
expect(generateContentStreamStub).to.be.calledWith(fakeRequestParams);
});
});

describe('templateGenerateContent', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/ai/src/methods/generate-content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ export async function generateContentStream(
() =>
generateContentStreamOnCloud(apiSettings, model, params, requestOptions)
);
return processStream(callResult.response, apiSettings); // TODO: Map streaming responses
return processStream(
callResult.response,
apiSettings,
callResult.inferenceSource
); // TODO: Map streaming responses
Copy link
Contributor

@dlarocque dlarocque Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO was added by me and it's already done- can you remove it pls (:

}

async function generateContentOnCloud(
Expand Down
Loading