Skip to content

Conversation

@hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Nov 13, 2025

generateContentStream was returning in_cloud no matter what.

Need to pass inferenceSource to processStream.

Added tests to catch.

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025

🦋 Changeset detected

Latest commit: b1e8f1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/ai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review November 13, 2025 19:57
@hsubox76 hsubox76 requested review from a team as code owners November 13, 2025 19:57
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 13, 2025

Size Report 1

Affected Products

  • @firebase/ai

    TypeBase (b228a2a)Merge (ffbe9bc)Diff
    browser67.4 kB67.4 kB+27 B (+0.0%)
    main71.7 kB71.7 kB+27 B (+0.0%)
    module67.4 kB67.4 kB+27 B (+0.0%)
  • @firebase/firestore

    TypeBase (b228a2a)Merge (ffbe9bc)Diff
    browser391 kB391 kB-7 B (-0.0%)
    main611 kB611 kB-7 B (-0.0%)
    module391 kB391 kB-7 B (-0.0%)
    react-native392 kB392 kB-7 B (-0.0%)
  • @firebase/firestore-lite

    TypeBase (b228a2a)Merge (ffbe9bc)Diff
    browser115 kB115 kB-7 B (-0.0%)
    main158 kB158 kB-7 B (-0.0%)
    module115 kB115 kB-7 B (-0.0%)
    react-native116 kB116 kB-7 B (-0.0%)
  • bundle

    TypeBase (b228a2a)Merge (ffbe9bc)Diff
    firestore (Query Cursors)257 kB257 kB-7 B (-0.0%)
    firestore (Read data once)245 kB245 kB-7 B (-0.0%)
    firestore (Read Write w Persistence)338 kB337 kB-7 B (-0.0%)
    firestore (Realtime updates)245 kB245 kB-7 B (-0.0%)
    firestore (Transaction)223 kB223 kB-7 B (-0.0%)
    firestore (Write data)224 kB224 kB-7 B (-0.0%)
    firestore-lite (Query Cursors)110 kB110 kB-7 B (-0.0%)
    firestore-lite (Read data once)81.6 kB81.6 kB-7 B (-0.0%)
    firestore-lite (Transaction)107 kB107 kB-7 B (-0.0%)
    firestore-lite (Write data)91.1 kB91.1 kB-7 B (-0.0%)
  • firebase

    TypeBase (b228a2a)Merge (ffbe9bc)Diff
    firebase-ai.js52.8 kB52.8 kB+18 B (+0.0%)
    firebase-compat.js809 kB809 kB-7 B (-0.0%)
    firebase-firestore-compat.js348 kB348 kB-7 B (-0.0%)
    firebase-firestore-lite.js138 kB138 kB-7 B (-0.0%)
    firebase-firestore.js454 kB454 kB-7 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ESjkGHC6zC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 13, 2025

Size Analysis Report 1

Affected Products

  • @firebase/ai

    • ChatSession

      Size

      TypeBase (b228a2a)Merge (ffbe9bc)Diff
      size22.3 kB22.3 kB+18 B (+0.1%)
      size-with-ext-deps40.0 kB40.1 kB+18 B (+0.0%)
    • GenerativeModel

      Size

      TypeBase (b228a2a)Merge (ffbe9bc)Diff
      size26.0 kB26.1 kB+18 B (+0.1%)
      size-with-ext-deps43.8 kB43.9 kB+18 B (+0.0%)
    • getGenerativeModel

      Size

      TypeBase (b228a2a)Merge (ffbe9bc)Diff
      size26.4 kB26.4 kB+18 B (+0.1%)
      size-with-ext-deps44.2 kB44.2 kB+18 B (+0.0%)
  • @firebase/firestore

    • addDoc

      Size

      TypeBase (b228a2a)Merge (ffbe9bc)Diff
      size140 kB140 kB-7 B (-0.0%)
      size-with-ext-deps211 kB211 kB-7 B (-0.0%)
    • doc

      Size

      TypeBase (b228a2a)Merge (ffbe9bc)Diff
      size34.0 kB34.0 kB-7 B (-0.0%)
      size-with-ext-deps103 kB103 kB-7 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ln7MvYsbjN.html

@hsubox76 hsubox76 changed the title Fix generateContentStream returning wrong inferenceSource. fix(ai): Fix generateContentStream returning wrong inferenceSource. Nov 19, 2025
callResult.response,
apiSettings,
callResult.inferenceSource
); // TODO: Map streaming responses
Copy link
Contributor

@dlarocque dlarocque Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO was added by me and it's already done- can you remove it pls (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants