fix!: remove nodejsScope option
#699
Conversation
|
Note: uses of this property will be removed from ESLint in eslint/eslint#20145. |
| it("creates a function scope following the global scope immediately and creates module scope", () => { | ||
| const ast = espree("import {x as v} from 'mod';"); | ||
|
|
||
| const scopeManager = analyze(ast, { ecmaVersion: 6, nodejsScope: true, sourceType: "module" }); | ||
|
|
||
| expect(scopeManager.scopes).to.have.length(3); | ||
| expect(scopeManager.isGlobalReturn()).to.be.true; | ||
|
|
||
| let scope = scopeManager.scopes[0]; | ||
|
|
||
| expect(scope.type).to.be.equal("global"); | ||
| expect(scope.block.type).to.be.equal("Program"); | ||
| expect(scope.isStrict).to.be.false; | ||
| expect(scope.variables).to.have.length(0); | ||
|
|
||
| scope = scopeManager.scopes[1]; | ||
| expect(scope.type).to.be.equal("function"); | ||
| expect(scope.block.type).to.be.equal("Program"); | ||
| expect(scope.isStrict).to.be.false; | ||
| expect(scope.variables).to.have.length(1); | ||
| expect(scope.variables[0].name).to.be.equal("arguments"); | ||
|
|
||
| scope = scopeManager.scopes[2]; | ||
| expect(scope.type).to.be.equal("module"); | ||
| expect(scope.variables).to.have.length(1); | ||
| expect(scope.variables[0].name).to.be.equal("v"); | ||
| expect(scope.variables[0].defs[0].type).to.be.equal("ImportBinding"); | ||
| expect(scope.references).to.have.length(0); | ||
| }); |
There was a problem hiding this comment.
This test was inherited from escope. I'm not sure why nodejsScope: true, sourceType: "module" combination was supported at all, and even less why it was supported by nesting scopes as: Global > Function > Module. For this combination, I think Global > Module > Function would make more sense for practical purposes as it could represent code that is going to be wrapped in a function that is in an ES module.
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
This pull request is blocked for the same reason noted in #525 (comment). |
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
This pull request was auto-closed due to inactivity. While we wish we could keep working on every request, we unfortunately don't have the bandwidth to continue here and need to focus on other things. You can resubmit this pull request if you would like to continue working on it. |
Prerequisites checklist
What is the purpose of this pull request?
Removes
nodejsScopeoption fromeslint-scope.What changes did you make? (Give an overview)
Removed the option and updated
analyze()to throw an error if it's passed.Related Issues
Fixes #697
Is there anything you'd like reviewers to focus on?