Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

The manifest creation step hardcoded amd64 and arm64 digest outputs, causing failures for CUDA images that only support amd64 (empty arm64 digest passed to docker buildx imagetools create).

Changes

  • Dynamic artifact discovery: Loop over all available .digest files instead of hardcoding architecture names
  • New all output variable: Collect all digests into single space-separated variable
  • Derive metadata from first digest: Extract registry, image, and tag from first discovered digest
  • Simplified imagetools create: Use unpacked all variable instead of explicit architecture outputs
  • Error handling: Added nullglob for safe glob expansion and validation that at least one digest exists

Applied to both base-manifest and eic-manifest jobs.

# Before
echo "amd64=$DIGEST_AMD64" >> $GITHUB_OUTPUT
echo "arm64=$DIGEST_ARM64" >> $GITHUB_OUTPUT
docker buildx imagetools create $TAG_ARGS \
  ${{ steps.digests.outputs.amd64 }} \
  ${{ steps.digests.outputs.arm64 }}

# After
shopt -s nullglob
for digest_file in /tmp/digests/${{ matrix.BUILD_IMAGE }}-*.digest; do
  # collect digests...
done
echo "all=$ALL_DIGESTS" >> $GITHUB_OUTPUT
docker buildx imagetools create $TAG_ARGS \
  ${{ steps.digests.outputs.all }}

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits November 27, 2025 01:05
…' output

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot AI changed the title [WIP] Update looping architecture artifacts in digest step Rewrite digests step to loop over architecture artifacts dynamically Nov 27, 2025
Copilot AI requested a review from wdconinc November 27, 2025 01:11
Copilot finished work on behalf of wdconinc November 27, 2025 01:11
@wdconinc wdconinc marked this pull request as ready for review November 27, 2025 01:13
@wdconinc wdconinc merged commit 2ad6051 into base-cuda Nov 27, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants