Skip to content

Add cuda_{runtim,devel} base and cuda concretization to GitHub Actions #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add cuda_{runtim,devel} base and cuda concretization to GitHub Actions #71

wants to merge 10 commits into from

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 26, 2025 •
edited
Loading

Briefly, what does this PR introduce?

This PR extends the GitHub Actions builds with base CUDA builds, and CUDA environment concretization. Single architecture.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Copilot AI review requested due to automatic review settings November 26, 2025 00:16
@wdconinc
Update build name to include BUILD_IMAGE
c1ac240
@wdconinc
Clarify environment variable context in workflow
b79d2fa 
Added comments to clarify environment variable handling in the workflow.
Copilot finished reviewing on behalf of wdconinc November 26, 2025 00:19
Copilot AI reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the GitHub Actions CI/CD pipeline to build CUDA-enabled base container images alongside the existing Debian-based images. The implementation adds support for NVIDIA CUDA 12.5.1 runtime and development base images for amd64 architecture only, as CUDA images are not available for arm64.

Key Changes:

  • Added new environment variables for CUDA version (12.5.1) and OS (ubuntu24.04) configuration
  • Introduced an env job to work around GitHub Actions matrix limitations with environment variables
  • Extended the base job matrix to build cuda_devel and cuda_runtime images for amd64 architecture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wdconinc and others added 2 commits November 25, 2025 18:30
@wdconinc
Allow for missing arm64 digest file
209e3aa 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wdconinc
Add 'final' container target to eic matrix
d93b99e
Copilot AI review requested due to automatic review settings November 26, 2025 01:42
Copilot finished reviewing on behalf of wdconinc November 26, 2025 02:00
Copilot AI reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings November 26, 2025 13:59
Copilot finished reviewing on behalf of wdconinc November 26, 2025 14:02
Copilot AI reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc
Rely on transitive dependencies in GitHub Actions
2f97229 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 26, 2025 14:09
Copilot finished reviewing on behalf of wdconinc November 26, 2025 14:12
Copilot AI reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI mentioned this pull request Nov 27, 2025
Merged

This comment was marked as resolved.

Sign in to view
@wdconinc
Rewrite digests step to loop over architecture artifacts dynamically (#…
2ad6051 
…73)

* Initial plan

* Rewrite digests step to loop over architecture artifacts and use 'all' output

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>

* Fix leading space issue and use nullglob for glob pattern handling

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>

* Add error handling when no digest files are found

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
wdconinc
wdconinc commented Nov 27, 2025
View reviewed changes
wdconinc
wdconinc commented Nov 27, 2025
View reviewed changes
wdconinc
wdconinc commented Nov 27, 2025
View reviewed changes
Copilot AI review requested due to automatic review settings November 27, 2025 01:18
Copilot finished reviewing on behalf of wdconinc November 27, 2025 01:21
Copilot AI reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc changed the title Add cuda_runtime and cuda_devel base image builds to GitHub Actions Add cuda_{runtim,devel} base and cuda concretization to GitHub Actions Nov 27, 2025
@wdconinc wdconinc enabled auto-merge (squash) November 27, 2025 03:05
@wdconinc wdconinc requested a review from veprbl November 27, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@veprbl veprbl veprbl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wdconinc @veprbl