fix: score value race condition #244
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix score_value stop condition race with concurrent trials
Key Changes:
Changed:
Bug Details:
When running with concurrency > 1, trials are added to the list in start order but complete out of order. The original code checked trials[-1] which could be a still-running trial when another trial completes.
Generated Summary:
stop.py, refined the logic to check for finished trials before proceeding, ensuring only completed trials are considered in the stopping criteria.This summary was generated with ❤️ by rigging