Skip to content

fix: score value race condition #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

fix: score value race condition #244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99fe4b9
bugfix score value race condition
vabruzzo Nov 30, 2025
6daa485
revert agent change
vabruzzo Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dreadnode/optimization/stop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,11 @@ def score_value(
"""

def stop(trials: list[Trial]) -> bool: # noqa: PLR0911
if not trials:
finished_trials = [t for t in trials if t.status == "finished"]
if not finished_trials:
return False

trial = trials[-1]
trial = finished_trials[-1]
value_to_check = trial.scores.get(metric_name) if metric_name else trial.score
if value_to_check is None:
return False
Expand Down
Loading