Skip to content

feat(structured-properties): add version field to StructuredProperties #15255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(structured-properties): add version field to StructuredProperties #15255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions metadata-ingestion/examples/structured_properties/structured_properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# - urn: urn:li:structuredProperty:io.acryl.privacy.retentionTime # optional if id is provided
qualified_name: io.acryl.privacy.retentionTime # required if urn is provided
type: number
version: "1.0.0"
cardinality: MULTIPLE
display_name: Retention Time
entity_types:
Expand Down
3 changes: 3 additions & 0 deletions metadata-ingestion/src/datahub/api/entities/structuredproperties/structuredproperties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class StructuredProperties(ConfigModel):
urn: Optional[str] = Field(None, validate_default=True)
qualified_name: Optional[str] = None
type: str
version: Optional[str] = None
value_entity_types: Optional[List[str]] = None
description: Optional[str] = None
display_name: Optional[str] = None
Expand Down Expand Up @@ -175,6 +176,7 @@ def generate_mcps(self) -> List[MetadataChangeProposalWrapper]:
if self.type_qualifier
else None
),
version=self.version,
),
)
return [mcp]
Expand Down Expand Up @@ -203,6 +205,7 @@ def from_datahub(cls, graph: DataHubGraph, urn: str) -> "StructuredProperties":
qualified_name=structured_property.qualifiedName,
display_name=structured_property.displayName,
type=structured_property.valueType,
version=structured_property.version,
description=structured_property.description,
entity_types=structured_property.entityTypes,
cardinality=structured_property.cardinality,
Expand Down
3 changes: 2 additions & 1 deletion ...on/tests/unit/api/entities/structuredproperties/example_structured_properties_golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"urn:li:entityType:datahub.dataFlow"
],
"description": "Retention Time is used to figure out how long to retain records in a dataset",
"immutable": false
"immutable": false,
"version": "1.0.0"
}
}
},
Expand Down
Loading