Skip to content

Conversation

@pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Nov 10, 2025

Summary

Add optional version field to StructuredProperties class to support versioning of structured property definitions. This allows tracking changes to property schemas over time.

Changes

  • Add version field to StructuredProperties model (optional string)
  • Update generate_mcps() to include version in metadata change proposals
  • Update from_datahub() to read version from stored properties
  • Add test coverage with example version value in YAML and golden file

Test Plan

  • Updated existing tests to verify version field serialization
  • Added example with explicit version value ("1.0.0") to test data
  • All unit tests pass
  • Linting passes

🤖 Generated with Claude Code

Add optional version field to StructuredProperties class to support
versioning of structured property definitions. This allows tracking
changes to property schemas over time.

Changes:
- Add version field to StructuredProperties model
- Update generate_mcps() to include version in metadata
- Update from_datahub() to read version from stored properties
- Add test coverage with example version value

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 10, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants