Skip to content

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 23, 2025

Refactors the LCP solver implementation under dart::math::lcp.

  • Introduces LcpSolver and LcpTypes abstractions for solver status, options, and results.
  • Adds a pivoting LemkeSolver and reorganizes Dantzig sources under dart/math/lcp/dantzig, preserving the legacy install path.
  • Updates constraints, benchmarks, and tests to the new headers and removes the deprecated namespace shim.
  • Ignores generated stub output in docs/readthedocs.

Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes
  • Add unit tests for new functionality
  • Document new methods and classes (documentation split to Add LCP documentation #2240)
  • Add Python bindings (dartpy) if applicable

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 23, 2025
@jslee02
Copy link
Member Author

jslee02 commented Nov 23, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.95%. Comparing base (7160371) to head (b932316).

Files with missing lines Patch % Lines
dart/math/lcp/pivoting/LemkeSolver.cpp 0.00% 30 Missing ⚠️
dart/math/lcp/LcpTypes.cpp 0.00% 18 Missing ⚠️
dart/math/lcp/LcpSolver.cpp 0.00% 6 Missing ⚠️
dart/math/lcp/LcpTypes.hpp 0.00% 2 Missing ⚠️
dart/math/lcp/dantzig/Common.hpp 50.00% 2 Missing ⚠️
dart/math/lcp/LcpSolver.hpp 0.00% 1 Missing ⚠️
dart/math/lcp/pivoting/LemkeSolver.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   61.05%   60.95%   -0.11%     
==========================================
  Files         353      359       +6     
  Lines       32144    32207      +63     
  Branches     4183     4187       +4     
==========================================
+ Hits        19627    19631       +4     
- Misses      12517    12576      +59     
Flag Coverage Δ
unittests 60.95% <9.09%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dart/constraint/BallJointConstraint.cpp 9.49% <ø> (ø)
dart/constraint/BoxedLcpConstraintSolver.cpp 53.70% <ø> (ø)
dart/constraint/ContactConstraint.cpp 76.62% <ø> (ø)
dart/constraint/DantzigBoxedLcpSolver.cpp 46.15% <ø> (ø)
dart/constraint/DantzigLCPSolver.cpp 0.00% <ø> (ø)
dart/constraint/JointConstraint.cpp 79.20% <ø> (ø)
dart/constraint/JointLimitConstraint.cpp 36.78% <ø> (ø)
dart/constraint/MimicMotorConstraint.cpp 77.24% <ø> (ø)
dart/constraint/PGSLCPSolver.cpp 0.00% <ø> (ø)
dart/constraint/PgsBoxedLcpSolver.cpp 71.42% <ø> (ø)
... and 18 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 merged commit abbc91f into main Nov 24, 2025
15 of 31 checks passed
@jslee02 jslee02 deleted the lcp/refactor branch November 24, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants