Skip to content

fix: recognizing "export USBMUXD_SOCKET_ADDRESS=UNIX:///tmp/usbmuxd" as tcp connections. #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: recognizing "export USBMUXD_SOCKET_ADDRESS=UNIX:///tmp/usbmuxd" as tcp connections. #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ios/usbmuxconnection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,19 @@ func ToUnixSocketPath(socketAddress string) string {
func GetUsbmuxdSocket() string {
socket_override := os.Getenv("USBMUXD_SOCKET_ADDRESS")
if socket_override != "" {
if strings.Contains(socket_override, ":") {
return "tcp://" + socket_override
} else {
// if it has a scheme, just use it
if strings.Contains(socket_override, "://") {
return socket_override
}
// if it is a file, use it as unix socket
if _, err := os.Stat(socket_override); err == nil {
return "unix://" + socket_override
}
// if it is a tcp address, use it
if strings.Contains(socket_override, ":") && strings.Contains(socket_override, ".") {
Copy link
Collaborator

@aluedeke aluedeke Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about hostname:port this?

Can't we fix this and maintain backward compatibility?

Check if there is a scheme on the string if so return it. If not fallback to the old logic.

return "tcp://" + socket_override
}
panic("Unknown socket address: " + socket_override)
}
switch runtime.GOOS {
case "windows":
Expand Down