fix: recognizing "export USBMUXD_SOCKET_ADDRESS=UNIX:///tmp/usbmuxd" as tcp connections. #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance GetUsbmuxdSocket to support various socket address formats, fix recognizing "export USBMUXD_SOCKET_ADDRESS=UNIX:///tmp/usbmuxd" as tcp connections.
Ylarod
changed the title
aluedeke
reviewed
Dec 1, 2025
| return "unix://" + socket_override | ||
| } | ||
| // if it is a tcp address, use it | ||
| if strings.Contains(socket_override, ":") && strings.Contains(socket_override, ".") { |
Collaborator
There was a problem hiding this comment.
how about hostname:port this?
Can't we fix this and maintain backward compatibility?
Check if there is a scheme on the string if so return it. If not fallback to the old logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance GetUsbmuxdSocket to support various socket address formats, fix recognizing "export USBMUXD_SOCKET_ADDRESS=UNIX:///tmp/usbmuxd" as tcp connections.